Make dedup critical crates compilation-compat with wasm #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafvayner
approved these changes
Apr 25, 2025
| [dependencies] | ||
| tokio = { version = "1.36", features = ["full"] } | ||
| tokio = { version = "1.44", features = ["sync"] } | ||
| async-scoped = { version = "0.7", features = ["use-tokio"] } |
Contributor
There was a problem hiding this comment.
I think async-scoped with use-tokio feature is likely still going to cause issues?
Collaborator
Author
There was a problem hiding this comment.
Just wanted to make it compilation-compat. We are not going to use in JS/web workers anyway.
| blake3 = "1.5.4" | ||
|
|
||
| [target.'cfg(target_family = "wasm")'.dependencies] | ||
| uuid = { version = "1", features = ["v4", "js"] } |
Contributor
There was a problem hiding this comment.
if you include the "js" feature for non-wasm build is that an error, I think the exports will just get ignored?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure about that
| utils = { path = "../utils" } | ||
| tempdir = "0.3.7" | ||
| tokio = { version = "1.36", features = ["full"] } | ||
| tempfile = "3.19.1" |
Collaborator
Author
There was a problem hiding this comment.
This is compilation-compat but won't work in web workers so we won't use this. But tempdir is very old and uses a very old version of rand, which uses a very old version of getrandom, which doesn't support the new wasm_js feature.
seanses
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randso we can use the new "wasm_js" feature for the underlyinggetrandomdependency.gen,gen_rangefunctions.tempdirtotempfilebecausetempdiruses a very old non-wasm compat version ofrand, and is merged into the latter and archived.