-
Notifications
You must be signed in to change notification settings - Fork 266
Add support for JinaAI Re-Rankers V1 #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's smaller and just created the PR to add support for TEI
Hello @Narsil, I managed to test the proposed changes in this PR and they solve the previous limitations. Thanks for the continued support in developing and maintaining this service! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR adds the
JinaBertClassificationHead
in order to support the JinaBERT re-ranking models as e.g.jinaai/jina-reranker-v1-turbo-en
. Note that JinaBERT's classification head is exactly the same as standard BERT's.Warning
This PR is not yet ready to be merged, as there seem to be some discrepancies between the Sentence Transformers and ONNX outputs (those are aligned), but the outputs for the default Candle backend is not, meaning that there may be something off somewhere. Also it has yet only been tested on CPU and MPS devices, CUDA support is still missing / pending.
In order to test the enabled models, please refer the the following revisions (until those are merged):
Fixes #579
Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.