Ensure consistentcy between labels and probabilities #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First notebook to try and reproduce the error.
- In predict_proba, probs were consistent with the model head's labels order - Now we make sure probs are always consistent with self.labels
|
Hi @tomaarsen! Let me know if you've liked the solution or not. There are ofc multiple ways of tackling this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587.
Problem: In certain cases (see issue), self.labels and self.model_head.classes_ are not in the same order. When calling self.predict_proba, the returned probabilities are ordered as per the model's head labels. This however contradicts the model's attribute order and is very counter intuitive.
Solution: I'm simply reordering the probabilities to ensure consistency. This completely solved the problem I had described in my issue.