Skip to content

[tests] Unify compilation + offloading tests in quantization #11910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 11, 2025
Merged

[tests] Unify compilation + offloading tests in quantization #11910

merged 5 commits into from
Jul 11, 2025

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Jul 10, 2025 •
edited
Loading

  • Create common test methods in the mixin class and remove them from the classes that override the mixin.
  • Unify where possible.

I have run the tests locally and they pass.

In a follow-up I will add a check to catch recompilation errors.

@sayakpaul sayakpaul requested a review from a-r-r-o-w July 10, 2025 09:42
a-r-r-o-w
a-r-r-o-w approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@sayakpaul sayakpaul merged commit 7a935a0 into main Jul 11, 2025
11 checks passed
@sayakpaul sayakpaul deleted the quant-compile-tests-unify branch July 11, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayakpaul @a-r-r-o-w