Skip to content

Fix mixed variant downloading #11611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Fix mixed variant downloading #11611

merged 2 commits into from
May 26, 2025

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented May 26, 2025

What does this PR do?

Oversight on my part when merging #11587 which fixes the case where only variant safetensors are present in a repo.

I missed that we always need to fallback to checking for non-variants if no variants are present otherwise mixed variant loading will break. Added a test to catch this case.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from sayakpaul May 26, 2025 09:37
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good too!

@DN6 DN6 merged commit 826f435 into main May 26, 2025
16 checks passed
@DN6 DN6 added the roadmap Add to current release roadmap label Jun 5, 2025
@DN6 DN6 moved this from In Progress to Done in Diffusers Roadmap 0.34 Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap Add to current release roadmap
Projects
Development

Successfully merging this pull request may close these issues.

3 participants