refactor(markdown): replace htmlparser2 with regex-based sanitizer#2040
Open
refactor(markdown): replace htmlparser2 with regex-based sanitizer#2040
Conversation
Replace htmlparser2 (56KB gzipped) with a zero-dependency regex-based HTML sanitizer for video/audio/source tags. Security approach: fail-closed - Only video, audio, source tags allowed - Strict attribute allowlist (src, controls, type, etc.) - Block javascript:, vbscript:, and data:text/html URIs - If ANY disallowed content detected, escape entire input
0f70018 to
310c50a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
htmlparser2dependency from package.jsonsanitizeMediaHtml()functionvideo,audio,sourcetags with strict attribute allowlistjavascript:,vbscript:, anddata:text/htmlURIsBundle Size Impact
Test plan