Skip to content

Conversation

@JustinGrilli
Copy link
Collaborator

@JustinGrilli JustinGrilli commented Jan 24, 2025

Overview

We encountered bugs while attempting to query projects in our secondary Tableau Online environment.
Not entirely sure why we do not have the same errors while querying our Production environment, but I assume it is because our Production enviroment has been around for long time, and newer environments don't support some legacy API endpoint parameters.

Changes

  • Changes to the get.projects functionality:
    • Added option for include_extra_fields, as some environments are clearly capable of including these extra fields, while others will error
      • Defaulting to True for now, as existing implementations expect these fields to be included
    • Changed "top_level" to be identified by if the project has a parent_project_id, as topLevelProject is not included by default
  • Changed publish.datasource and publish.datasource to allow publishing to sub-projects by name, if no ID is provided
    • Also fixed a small printing bug, where it would print the None project, rather than the project_name it was searching for, when no project was found

Testing

  • Ran script locally on both our Production and Staging Tableau Online environments, with all variations of the updated arguments
    • Script was able to both query and publish with these changes

Copy link
Collaborator

@frances-fang frances-fang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JustinGrilli JustinGrilli added the bug Something isn't working label Jan 24, 2025
@JustinGrilli JustinGrilli merged commit 159b798 into main Jan 24, 2025
1 check passed
@JustinGrilli JustinGrilli deleted the fix-get_project-bugs branch January 24, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants