Fix enabling coin with birthday height

[abdrasulov]

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of settings flow results when returning from a configuration screen.
  • Navigation now preserves and routes screen results more reliably, reducing missed updates after going back or canceling.
  • Fixed the way certain screens are opened so their return values are handled consistently.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 104cd4b5-3df9-496d-8463-b36def908050

📥 Commits

Reviewing files that changed from the base of the PR and between ee68a21 and da9fc2f.

📒 Files selected for processing (3)

• app/src/main/java/io/horizontalsystems/bankwallet/modules/managewallets/ManageWalletsPage.kt
• app/src/main/java/io/horizontalsystems/bankwallet/modules/nav3/HSNavigation.kt
• app/src/main/java/io/horizontalsystems/bankwallet/modules/nav3/ResultEffect.kt

---

📝 Walkthrough

Walkthrough

Introduces a observeResult<T> composable that generates a stable saveable UUID result key and connects it to ResultEffect, and adds slideFromRightForResult(screen, resultKey) to HSNavigation. ManageWalletsPage is refactored to use these new APIs instead of the previous inline-closure-based pattern.

Changes

Navigation Result Observation Refactor

Layer / File(s)	Summary
observeResult helper and slideFromRightForResult method app/src/.../nav3/ResultEffect.kt, app/src/.../nav3/HSNavigation.kt	Adds observeResult<T> composable that generates a rememberSaveable UUID result key and wires it into ResultEffect with a synchronous callback. Adds slideFromRightForResult(screen, resultKey) to HSNavigation that assigns the key, sets SlideFromRight nav type, and pushes the screen onto the back stack.
ManageWalletsPage callsite refactor app/src/.../managewallets/ManageWalletsPage.kt	Replaces the previous inline-closure slideFromRightForResult call with a two-step approach: observeResult<BirthdayHeightConfigPage.Result> to dispatch config or cancellation to restoreSettingsViewModel, then navigation.slideFromRightForResult(BirthdayHeightConfigPage(...), resultKey).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: fixing coin enabling flow when birthday height is involved.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch coin-manager-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}