Add option to set HA as launcher #5348
Conversation
fpetrovski
force-pushed
the
feature/launcher
branch
from
ef632b8 to
1712549
Compare
| @@ -37,6 +37,11 @@ | |||
| </PreferenceCategory> | |||
| <PreferenceCategory | |||
| android:title="@string/other_settings"> | |||
| <Preference | |||
There was a problem hiding this comment.
Does this need this amount of promotion (in settings! the first item!) for a feature 99% of users will not use?
There was a problem hiding this comment.
I decided to position it there since it's somewhat related to fullscreen, screen orientation and keep screen on, in the sense that it changes how the device behaves.
I can move it below those 3.
There was a problem hiding this comment.
Although this largely compliments most of the apps WebView features this feels like a big behavior change for a device that not every user will want to enable on every device. Maybe a new category is a good idea for this so we can also describe why a user may want to set the app as the launcher? They may not understand that they will need to do things like updating the dashboard to add links to apps etc...
One of the reasons why its not good to list it at the top is that users may enable it on accident and that may not lead to a good experience.
There was a problem hiding this comment.
Another thought: make the launcher an activity-alias that can be enabled/disabled and require the user to opt-in to the setting to choose HA as a launcher (= enable the activity alias). We should avoid the possibility that users accidentally set HA as a launcher.
There was a problem hiding this comment.
make the launcher an activity-alias that can be enabled/disabled
@jpelgrom I can create a new SwitchPreference for this.
Maybe a new category is a good idea for this
@dshokouhi, would it be acceptable if I add the switch and based on the state show or hide the current Preference item that navigates to the settings? The new category could be simply named "Launcher" or "Kiosk", although for it to be truly a kiosk app, a few other things need to be implemented.
Another option is to open a new page like "Manage Sensors" or "Notification History", but I'm not sure if it makes sense to have an entire page just for one option. Additionally if the app is being slowly converted to JetpackCompose, adding another fragment does not help :)
There was a problem hiding this comment.
@dshokouhi, would it be acceptable if I add the switch and based on the state show or hide the current Preference item that navigates to the settings?
Yup sounds good with me, I like @jpelgrom suggestion to make it explicit opt-in
The new category could be simply named "Launcher" or "Kiosk", although for it to be truly a kiosk app, a few other things need to be implemented.
Could be a good start to a set of new features ;) We can maybe leave it as generic and update it if anything else gets added to compliment it.
Another option is to open a new page like "Manage Sensors" or "Notification History", but I'm not sure if it makes sense to have an entire page just for one option. Additionally if the app is being slowly converted to JetpackCompose, adding another fragment does not help :)
That is an option and in fact some of the sub settings pages have already been converted to Compose so we can interchange them. For now with just 1 option it may not make sense. However a dedicated page is a good place for an extended description if required.
| @@ -58,6 +58,8 @@ import kotlinx.coroutines.sync.Mutex | |||
| import kotlinx.coroutines.sync.withLock | |||
| import timber.log.Timber | |||
|
|
|||
| private const val UNKNOWN_LAUNCHER_LABEL = "unknown app" | |||
There was a problem hiding this comment.
Absolutely, thanks for pointing it out.
Summary
This PR is related to #5023 where it was discussed to allow HA Companion app to become a launcher.
A new option was added to the preference settings, under "Other Settings" Preference Category.
Checklist
Screenshots
Any other notes