Skip to content

fix(ruby) symbols, string interpolation, class names with underscores #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimtng wants to merge 9 commits into
base: main
Choose a base branch
from
+250 −84
Open

fix(ruby) symbols, string interpolation, class names with underscores #4213

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
67644b9
fix(ruby) symbols, string interpolation, class names with underscores
jimtng Feb 25, 2025
1ce45f3
remove negative lookbehind
jimtng Mar 5, 2025
0be49c6
reduce relevance of string interpolation
jimtng Mar 5, 2025
f53b568
remove relevance
jimtng Mar 5, 2025
094e626
match single-letter class name
jimtng Mar 5, 2025
2017467
match single char constant
jimtng Mar 6, 2025
34ee845
match class inheritance
jimtng Mar 6, 2025
1e751a9
clean up last commas
jimtng Mar 6, 2025
eace348
remove the use of lookbehind
jimtng Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/languages/ruby.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export default function(hljs) {
METHOD_DEFINITION,
{
// swallow namespace qualifiers before symbols
begin: hljs.IDENT_RE + '::'
begin: '::'
Copy link
Member

@joshgoebel joshgoebel Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this works.

},
{
className: 'symbol',
Expand All @@ -384,7 +384,7 @@ export default function(hljs) {
},
{
className: 'symbol',
begin: '(?<!:):(?!\\s|:)',
begin: ':(?!\\s)',
contains: [
{ begin: /'/, end: /'/ },
{
Expand Down