-
Notifications
You must be signed in to change notification settings - Fork 100
Update dependabot configuration #2344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We are trying to achieve two things: * Make it possible for dependabot to upgrade the containers automatically * Collect the image and version of the containers we use for testing in one place Note that the test suite will still create and start the containers programmatically, but it will read the first FROM line in each Dockerfile to extract the image and version to use. It will ignore everything else. My initial plan was to configure each container using the Dockerfile directly, but I prefer to reuse the exsisting Testcontainers classes for each database (for example, PostgreSQLContainer) because they contain out-of-the-box configuration that I would need to copy somewhere else. In any case, this is a good starting point and we can improve it later.
Includes: * Update project dependencies * Update images in Dockerfile files under tooling/docker/ * Update images we use as services in the GitHub workflow (mysql and postgres to test the examples)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🎉
it's a shame that those more specialized containers do not allow for just passing the new ImageFromDockerfile
. But your parsing logic looks good 😉 so let's give it a try 😃
@@ -14,5 +14,49 @@ updates: | |||
patterns: | |||
- "*" | |||
allow: | |||
- dependency-name: "actions/*" | |||
- dependency-name: "redhat-actions/*" | |||
- dependency-type: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably fine to include all actions to check for the updates since we currently only have the official actions/
and the codeql
actions used in the workflows...
For the background, why it was originally limited: the idea was to only allow updates for the explicitly defined trusted sources of actions. So I'll let you decide how you'd like to define that 😃, maybe just
- dependency-type: all | |
- dependency-name: "actions/*" | |
- dependency-name: "github/codeql-action/*" |
?
Fix #1136
Built on top of #2341
Includes:
postgres to test the examples)
@marko-bekhta, could you have a look at the dependabot configuration in this commit and let me know if it makes sense?