HHH-18891 fix of an AssertionError when using a NotFound annotation #10208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbellade
reviewed
May 26, 2025
There was a problem hiding this comment.
Thanks @peter1123581321, your approach looks reasonable to me. Let a few minor comments.
...e/src/main/java/org/hibernate/sql/results/graph/embeddable/internal/EmbeddableAssembler.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/hibernate/sql/results/graph/embeddable/internal/EmbeddableAssembler.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/notfound/HHH18891Test.java
Outdated
Show resolved
Hide resolved
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
peter1123581321
force-pushed
the
HHH-18891
branch
from
dd1c68e to
13904b0
Compare
|
@mbladel Is this one good to go? |
mbellade
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug reported in HHH-18891 describes an assertion that fails because it expects the initializer state to be KEY_RESOLVED before it resolves the instance.
I added an if statement in EmbeddableAssembler to ensure that the key is resolved if the state is UNINITIALIZED.
The tests in the PR are based on hibernate/hibernate-test-case-templates#454
as presented in https://hibernate.atlassian.net/browse/HHH-18891 but have been simplified a bit for readability.
I guess that there are other possibilities to catch the given scenario earlier or with a more specific approach.
But at least none of the other tests fail with the fix. :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.