perf(drivers): Use smallvec for AvailBufferToken #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is hypothetically possible to have send and receive buffers of sizes up to that of the virt queue, in reality we only ever have up to 2 items here. smallvec lets us handle this case very efficiently while still theoretically allowing for larger amounts of items. Signed-off-by: Jens Reidel <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is hypothetically possible to have send and receive buffers of sizes up to that of the virt queue, in reality we only ever have up to 2 items here. smallvec lets us handle this case very efficiently while still theoretically allowing for larger amounts of items.
This should get rid of a lot of the heap allocations in
fill_queue.Improves throughput by about ~20% in my benchmarks.