Skip to content

Change default image filename from {name} to hermit-app #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Change default image filename from {name} to hermit-app #1706

wants to merge 5 commits into from

Conversation

shehreenr
Copy link

@shehreenr shehreenr commented May 4, 2025 •
edited by mkroening
Loading

Related to #638.

@mkroening mkroening changed the title Supply correct image filename Change default image filename from {name} to hermit-app May 7, 2025
@mkroening mkroening self-assigned this May 7, 2025
mkroening
mkroening requested changes May 22, 2025
View reviewed changes
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI complains about the formatting.

The issue is that you removed the trailing newline from the file. cargo fmt should fix the formatting. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkroening mkroening mkroening requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shehreenr @mkroening