Casl 1434 mom10 app service #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Amanowicz <[email protected]>
Signed-off-by: Jakub Amanowicz <[email protected]>
Signed-off-by: Jakub Amanowicz <[email protected]>
Signed-off-by: Jakub Amanowicz <[email protected]>
Signed-off-by: Jakub Amanowicz <[email protected]>
Code Coverage
Files
|
Marcin-Here
reviewed
Nov 17, 2025
here-naksha-app-service/src/test/resources/unit_test_data/Mom10/testCreate/features.json
Show resolved
Hide resolved
...-naksha-app-service/src/test/resources/unit_test_data/Mom10/testDropNamespaces/features.json
Show resolved
Hide resolved
...-naksha-app-service/src/test/resources/unit_test_data/Mom10/testDropNamespaces/response.json
Show resolved
Hide resolved
here-naksha-app-service/src/test/resources/unit_test_data/Mom10/testOldNamespaces/features.json
Show resolved
Hide resolved
here-naksha-app-service/src/test/resources/unit_test_data/Mom10/testRead/features.json
Show resolved
Hide resolved
hirenkp2000
requested changes
Nov 17, 2025
...sha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/ReadFeatureApiTask.java
Show resolved
Hide resolved
...sha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/ReadFeatureApiTask.java
Show resolved
Hide resolved
...service/src/main/java/com/here/naksha/app/service/http/tasks/processor/TagsPreProcessor.java
Outdated
Show resolved
Hide resolved
...ha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/WriteFeatureApiTask.java
Show resolved
Hide resolved
...ha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/WriteFeatureApiTask.java
Outdated
Show resolved
Hide resolved
...sha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/ReadFeatureApiTask.java
Show resolved
Hide resolved
...ha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/WriteFeatureApiTask.java
Show resolved
Hide resolved
here-naksha-app-service/src/test/java/com/here/naksha/app/service/Mom10Test.java
Show resolved
Hide resolved
here-naksha-app-service/src/test/java/com/here/naksha/app/service/Mom10Test.java
Show resolved
Hide resolved
here-naksha-app-service/src/test/java/com/here/naksha/app/service/Mom10Test.java
Show resolved
Hide resolved
Signed-off-by: Jakub Amanowicz <[email protected]>
Signed-off-by: Jakub Amanowicz <[email protected]>
Code Coverage
Files
|
Signed-off-by: Jakub Amanowicz <[email protected]>
Code Coverage
Files
|
Signed-off-by: Jakub Amanowicz <[email protected]>
Code Coverage
Files
|
hirenkp2000
requested changes
Nov 19, 2025
| } | ||
| } else { | ||
| if (responseType.equals(HttpResponseType.FEATURE)) { | ||
| return transformWriteResultToXyzFeatureResponse(wrResult, XyzFeature.class); |
Member
There was a problem hiding this comment.
I think we need MOM10 post processor here as well?
| HttpResponse<String> createResp = getNakshaClient().post("hub/spaces/" + SPACE_ID + "/features", createFeatureJson, streamId); | ||
| assertThat(createResp).hasStatus(200); | ||
|
|
||
| // And: We do little hacking - patching the feature with different `modelVersion` (MOM 10) so that MOM 10 transformation will happen |
Member
There was a problem hiding this comment.
Correct me if I'm wrong, but this Patch step is not adding any value to the test and can be removed (to avoid confusion for other devs). It is fine, if this test is just about Creating MOM10 and Reading back MOM10 Feature and validating that we still get the originally submitted MOM10 Feature as is, without old Delta and Meta namespaces.
Contributor
Author
There was a problem hiding this comment.
I did to demonstrate that deltaNs and metaNs that were the user's input have nothing to do with what's been added by Naksha - the main excercise here is comparison between initial and final values in old namespaces
Member
There was a problem hiding this comment.
We also need to check that the synchronous Response obtained on "Write Request" does not have old Delta and Meta namespaces. It can be added to any of the test cases here.
Contributor
Author
There was a problem hiding this comment.
It is already covered in shouldCreateMom10Feature
Signed-off-by: Jakub Amanowicz <[email protected]>
Code Coverage
Files
|
hirenkp2000
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.