Skip to content

Addressed copilot review#1282

Merged
VisLab merged 1 commit intohed-standard:mainfrom
VisLab:fix_extras
Mar 25, 2026
Merged

Addressed copilot review#1282
VisLab merged 1 commit intohed-standard:mainfrom
VisLab:fix_extras

Conversation

@VisLab
Copy link
Copy Markdown
Member

@VisLab VisLab commented Mar 25, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines HED query parsing and reporting, primarily by clarifying how the @tag prefix is handled and by improving readability of query-parse error details returned to callers.

Changes:

  • Treat @tag as a prefix handled by Expression.__init__ rather than a standalone token kind in Token.
  • Normalize exception whitespace in get_query_handlers so parse errors are returned as single-line, more readable issue strings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
hed/models/query_util.py Removes @ from the token mapping and updates the NotInLine comment to reflect prefix handling.
hed/models/query_service.py Collapses whitespace in exception details when building [BadQuery ...] issue messages.

@VisLab VisLab merged commit 3ba4a4b into hed-standard:main Mar 25, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants