-
Notifications
You must be signed in to change notification settings - Fork 714
Use proper GHC option handling for passing multi-repl flags #10995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc7fc99
to
f6c0a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for the review Brandon and Rodrigo. |
fd0e0f8
to
3c92519
Compare
Yes, and I noticed a few minutes ago that |
Anyway if you rebase on The good news is, it's not part of any of the released packages, it's part of the tests. |
@geekosaur we have the index-state pinned (your PR that bumps it and runs into the splitmix issue isn't merged yet). So, how would you explain the failure here — with the old index-state? |
|
Oh, my bad. I'm curious now what we were thinking when decided to pin one but not the other... |
The idea was that we would find out about transitive deps that broke things before we moved the pin as part of a release. Which fails when someone breaks us while we're making a release.... |
Speaking of which, I need to move the patchup to where it'll be caught by the other project files: I bet bootstrap on Macs is now broken. |
This refactoring modifies the logic to start the multi-repl to use runGHCWithResponseFile rather than directly constructing a command line. Towards #10881
3c92519
to
02b6d8c
Compare
This refactoring modifies the logic to start the multi-repl to use runGHCWithResponseFile rather than directly constructing a command line.
Towards #10881
Please read Github PR Conventions and then fill in one of these two templates.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: