Skip to content

fix(utilities): require dot prefix in has_image_extension checks#1661

Open
laurigates wants to merge 1 commit intohacksider:mainfrom
laurigates:pr/fix-has-image-extension-v2
Open

fix(utilities): require dot prefix in has_image_extension checks#1661
laurigates wants to merge 1 commit intohacksider:mainfrom
laurigates:pr/fix-has-image-extension-v2

Conversation

@laurigates
Copy link
Contributor

@laurigates laurigates commented Feb 22, 2026

Summary

has_image_extension() uses endswith(("png", "jpg", "jpeg")) without dot prefixes, so any path ending in those letters matches (e.g., notapngTrue).

This adds the . prefix to each extension tuple entry so only actual file extensions match.

Changes

  • modules/utilities.py: Add . prefix to extension strings in has_image_extension()

Testing

  • has_image_extension("photo.png")True (unchanged)
  • has_image_extension("notapng")False (was incorrectly True)
  • has_image_extension("file.jpg")True (unchanged)

🤖 Generated with Claude Code

Summary by Sourcery

Bug Fixes:

  • Ensure has_image_extension() only matches real file extensions (e.g., .png, .jpg, .jpeg) instead of any path ending with those letter sequences.

Without the dot prefix, `endswith(("png", "jpg", "jpeg"))` matches any path
ending in those letters (e.g., "notapng"), causing false positives in image
detection.

This adds the `.` prefix to each extension in the tuple so only actual file
extensions match.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 22, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the image file extension check in utilities to require a leading dot so only real file extensions are matched, not arbitrary trailing characters.

File-Level Changes

Change Details Files
Tighten image extension detection to match only real file extensions with a leading dot.
  • Change has_image_extension to call endswith with extensions including a leading '.' for png, jpg, and jpeg
  • Preserve case-insensitive behavior by continuing to lower() the input path before checking extensions
modules/utilities.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant