fix(utilities): require dot prefix in has_image_extension checks#1661
Open
laurigates wants to merge 1 commit intohacksider:mainfrom
Open
fix(utilities): require dot prefix in has_image_extension checks#1661laurigates wants to merge 1 commit intohacksider:mainfrom
laurigates wants to merge 1 commit intohacksider:mainfrom
Conversation
Without the dot prefix, `endswith(("png", "jpg", "jpeg"))` matches any path
ending in those letters (e.g., "notapng"), causing false positives in image
detection.
This adds the `.` prefix to each extension in the tuple so only actual file
extensions match.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the image file extension check in utilities to require a leading dot so only real file extensions are matched, not arbitrary trailing characters. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_image_extension()usesendswith(("png", "jpg", "jpeg"))without dot prefixes, so any path ending in those letters matches (e.g.,notapng→True).This adds the
.prefix to each extension tuple entry so only actual file extensions match.Changes
modules/utilities.py: Add.prefix to extension strings inhas_image_extension()Testing
has_image_extension("photo.png")→True(unchanged)has_image_extension("notapng")→False(was incorrectlyTrue)has_image_extension("file.jpg")→True(unchanged)🤖 Generated with Claude Code
Summary by Sourcery
Bug Fixes: