Skip to content

fix/only call persistDoc if ydoc has changes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix/only call persistDoc if ydoc has changes #20

merged 2 commits into from
Jan 21, 2025

Conversation

stanley2058
Copy link
Collaborator

Only call persistDoc if transaction is greater than 0

EastSun5566
EastSun5566 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@EastSun5566 EastSun5566 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Yukaii
Copy link
Member

Yukaii commented Jan 21, 2025

The test is not passing

  X Assertion failed
  TestError: Test Failed
      at fail (file:///y-socketio-redis/node_modules/.pnpm/[email protected]/node_modules/lib0/testing.js:622:9)
      at Module.assert (file:///y-socketio-redis/node_modules/.pnpm/[email protected]/node_modules/lib0/testing.js:526:67)
      at testSyncAndCleanup (file:///y-socketio-redis/tests/socketio.tests.js:147:5)
      at async run (file:///y-socketio-redis/node_modules/.pnpm/[email protected]/node_modules/lib0/testing.js:168:9)
      at async runTests (file:///y-socketio-redis/node_modules/.pnpm/[email protected]/node_modules/lib0/testing.js:589:21)
Failure: sync and cleanup in 1.54s
repeat: npm run test -- --filter "\[5/"

@Yukaii Yukaii merged commit 8521ccb into main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EastSun5566 EastSun5566 EastSun5566 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stanley2058 @Yukaii @EastSun5566