fix/recovery mechanism for orphan streams #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galaxian85
approved these changes
Jan 20, 2025
jackycute
reviewed
Jan 20, 2025
Comment on lines
+123
to
+144
| checkAndRecoverWorkerStream: redis.defineScript({ | ||
| NUMBER_OF_KEYS: 1, | ||
| SCRIPT: ` | ||
| local found = false | ||
| local messages = redis.call("XREAD", "COUNT", 0, "STREAMS", "${this.redisWorkerStreamName}", "0-0") | ||
|
|
||
| if messages and #messages > 0 then | ||
| local entries = messages[1][2] | ||
| for _, entry in ipairs(entries) do | ||
| -- Each entry is an array where entry[2] is the message fields | ||
| if entry[2][2] == KEYS[1] then | ||
| found = true | ||
| break | ||
| end | ||
| end | ||
| end | ||
|
|
||
| -- If stream not found in y:worker and the stream exists, add it | ||
| if not found and redis.call("TYPE", KEYS[1]).ok == "stream" then | ||
| redis.call("XADD", "${this.redisWorkerStreamName}", "*", "compact", KEYS[1]) | ||
| end | ||
| `, |
There was a problem hiding this comment.
加上這個 redis 的 CPU 或是記憶體會有顯著的用量提升嗎？
There was a problem hiding this comment.
local 看不太出來，目前只讓他在連線時跑一次
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the stream will try to add itself to
y:workeron the socket connection.