Skip to content

Unit testing for Projects router #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2025
Merged

Unit testing for Projects router #1920

merged 5 commits into from
Jun 24, 2025

Conversation

jng34
Copy link
Member

@jng34 jng34 commented May 9, 2025

Fixes #1891

What changes did you make and why did you make them ?

  • Wrote unit tests for projects.router
  • Necessary to isolate and independently test each route to ensure functionality

Screenshots of Passed Tests

image

@JackHaeg JackHaeg requested a review from dannyprikaz May 15, 2025 22:44
dannyprikaz
dannyprikaz approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@dannyprikaz dannyprikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'should return an updated project with PUT /api/projects/:ProjectId' is a weird endpoint. It doesn't really feel like an "UPDATE" to me. I think it's ultimately a "READ," but I'm not too worried about it.

@dannyprikaz dannyprikaz merged commit 1e51ae5 into hackforla:development Jun 24, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyprikaz dannyprikaz dannyprikaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create New Unit Tests for ./backend/routers/projects.router.js
3 participants
@jng34 @dannyprikaz @JackHaeg