Refactored away old Button components #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snigdhat1
reviewed
May 19, 2025
| <IconButton /> | ||
| <IconButton disabled /> | ||
| <SearchButton /> | ||
| <SearchButton disabled /> |
There was a problem hiding this comment.
qq: is this intentional to render both buttons? seems like its more for testing but just wanted to make sure
There was a problem hiding this comment.
I was showcasing both buttons for a screenshot I included in my original tailwind button refactor PR (I think HfLA requires a screenshot for any frontend changes in the PR description?).
snigdhat1
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes