feat(labels): add printable label offset for partially used sheets#18781
Open
BlackFenix2 wants to merge 1 commit intogrokability:masterfrom
Open
feat(labels): add printable label offset for partially used sheets#18781BlackFenix2 wants to merge 1 commit intogrokability:masterfrom
BlackFenix2 wants to merge 1 commit intogrokability:masterfrom
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when using Avery sheets or any other multi label page, I have been unable to re-use sheets if i did not print all of the label slots available.
I added a simple offset option to skip empty positions on a partially used sheet. This works fine for multiple labels per page and does not cause breaks with tapes like the brother TZE label generations.
I did use copilot to help find the controller that handles generating the bulk label PDF. I tested the implementation on my dev server and provided screenshots as proof. Please let me know if you have any questions.