Use a sql recursive query for node tree invalidation and dto tree building #791
Conversation
…into use_sql_recursive_for_node_tree_invalidation
…into use_sql_recursive_for_node_tree_invalidation
| "FROM NodeHierarchy nh " + | ||
| "ORDER BY nh.depth DESC") | ||
| List<String> findAllDescendants(UUID nodeUuid); | ||
| "SELECT cast(nh.id_node AS VARCHAR) " + |
There was a problem hiding this comment.
is "cast()" needed here ?
There was a problem hiding this comment.
Yes otherwise the result is of type string and not uuid
There was a problem hiding this comment.
does it work without casting neither in postgres nor H2? or not working only in H2?
| return nodesRepository.findAllChildrenUuids(parentUuid); | ||
| } | ||
|
|
||
| // TODO Remove this method and use getAllChildrenUuids |
There was a problem hiding this comment.
since we've already changed some "getChildren" to "getChildrenUuids" here, why don't we make this change right now by renaming all occurences ?
There was a problem hiding this comment.
This method is used in many places and you have to test a lot of things
A TS was created
| @@ -598,7 +598,7 @@ void testNodeModificationInfos() throws Exception { | |||
|
|
|||
| List<AbstractNode> children = root.getChildren(); | |||
| assertEquals(2, children.size()); | |||
| NetworkModificationNode n1 = (NetworkModificationNode) children.get(0); | |||
| NetworkModificationNode n1 = (NetworkModificationNode) (children.get(0).getName().equals("n1") ? children.get(0) : children.get(1)); | |||
There was a problem hiding this comment.
we could replace by .stream().findFirst by name instead ?
| */ | ||
| assertChildrenEquals(Set.of(node1, node2), root.getChildren()); | ||
|
|
||
| node2.setName("niark"); | ||
| node1.setName("condriak"); | ||
| node1.setModificationGroupUuid(UUID.randomUUID()); | ||
| createNode(root.getStudyId(), children.get(1), node2, userId); | ||
| createNode(root.getStudyId(), children.get(1), node1, userId); | ||
| AbstractNode child = children.get(0).getName().equals("loadflow") ? children.get(0) : children.get(1); |
| " FROM NODE n " + | ||
| " INNER JOIN NodeHierarchy nh ON n.parent_node = nh.id_node " + | ||
| ") " + | ||
| "SELECT nh.id_node::text " + | ||
| "FROM NodeHierarchy nh " + | ||
| "ORDER BY nh.depth DESC") |
There was a problem hiding this comment.
Are we sure that ordering by depth was not necessary anywhere?
SlimaneAmar
force-pushed
the
use_sql_recursive_for_node_tree_invalidation
branch
from
a545215 to
d62860d
Compare
|
No description provided.