[WIP] Fixes dependency cycles and add eslint no-cycle rule #2624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meklo
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 788 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 731 | 11 | 46 | 0 |
Click to see the invalid file list
- src/components/custom-aggrid/custom-aggrid-filters/custom-aggrid-filter.type.ts
- src/components/custom-aggrid/custom-aggrid.type.ts
- src/components/dialogs/limits/limits.type.ts
- src/components/dialogs/parameters/dynamicsimulation/dynamic-simulation.type.ts
- src/components/dialogs/parameters/non-evacuated-energy/non-evacuated-energy.type.ts
- src/components/dialogs/parameters/sensi/sensitivity-analysis.type.ts
- src/components/dialogs/parameters/voltageinit/voltage-init.type.ts
- src/components/graph/util/shared-functions.ts
- src/components/result-view-tab.type.ts
- src/components/results/common/filter.type.ts
- src/components/results/securityanalysis/security-analysis-columns-definition.ts
| @@ -0,0 +1,62 @@ | |||
| import { ColDef, GridApi, IFilterOptionDef } from 'ag-grid-community'; | |||
There was a problem hiding this comment.
Suggested change
| import { ColDef, GridApi, IFilterOptionDef } from 'ag-grid-community'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import { ColDef, GridApi, IFilterOptionDef } from 'ag-grid-community'; |
| @@ -0,0 +1,13 @@ | |||
| import { TableSortKeysType } from '../../redux/reducer'; | |||
There was a problem hiding this comment.
Suggested change
| import { TableSortKeysType } from '../../redux/reducer'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import { TableSortKeysType } from '../../redux/reducer'; |
| @@ -0,0 +1,22 @@ | |||
| import { TemporaryLimit } from '../../../services/network-modification-types'; | |||
There was a problem hiding this comment.
Suggested change
| import { TemporaryLimit } from '../../../services/network-modification-types'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import { TemporaryLimit } from '../../../services/network-modification-types'; |
| @@ -0,0 +1,34 @@ | |||
| import yup from '../../../utils/yup-config'; | |||
There was a problem hiding this comment.
Suggested change
| import yup from '../../../utils/yup-config'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import yup from '../../../utils/yup-config'; |
| @@ -0,0 +1,22 @@ | |||
| import yup from '../../../utils/yup-config'; | |||
There was a problem hiding this comment.
Suggested change
| import yup from '../../../utils/yup-config'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import yup from '../../../utils/yup-config'; |
| @@ -0,0 +1,4 @@ | |||
| export enum EquipmentsSelectionType { | |||
There was a problem hiding this comment.
Suggested change
| export enum EquipmentsSelectionType { | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| export enum EquipmentsSelectionType { |
| @@ -0,0 +1,57 @@ | |||
| import { NetworkModificationNodeData, NodeType, RootNodeData } from '../tree-node.type'; | |||
There was a problem hiding this comment.
Suggested change
| import { NetworkModificationNodeData, NodeType, RootNodeData } from '../tree-node.type'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import { NetworkModificationNodeData, NodeType, RootNodeData } from '../tree-node.type'; |
| @@ -0,0 +1,8 @@ | |||
| import ComputingType from './computing-status/computing-type'; | |||
There was a problem hiding this comment.
Suggested change
| import ComputingType from './computing-status/computing-type'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import ComputingType from './computing-status/computing-type'; |
| @@ -0,0 +1,5 @@ | |||
| export interface Filter { | |||
There was a problem hiding this comment.
Suggested change
| export interface Filter { | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| export interface Filter { |
| @@ -0,0 +1,622 @@ | |||
| import { IntlShape } from 'react-intl'; | |||
There was a problem hiding this comment.
Suggested change
| import { IntlShape } from 'react-intl'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import { IntlShape } from 'react-intl'; |
There was a problem hiding this comment.
license-eye has totally checked 787 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 731 | 10 | 46 | 0 |
Click to see the invalid file list
- src/components/custom-aggrid/custom-aggrid-filters/custom-aggrid-filter.type.ts
- src/components/custom-aggrid/custom-aggrid.type.ts
- src/components/dialogs/limits/limits.type.ts
- src/components/dialogs/parameters/dynamicsimulation/dynamic-simulation.type.ts
- src/components/dialogs/parameters/sensi/shared-functions.ts
- src/components/dialogs/parameters/voltageinit/voltage-init.type.ts
- src/components/graph/util/shared-functions.ts
- src/components/result-view-tab.type.ts
- src/components/results/common/filter.type.ts
- src/components/results/securityanalysis/security-analysis-columns-definition.ts
| @@ -0,0 +1,425 @@ | |||
| import { | |||
There was a problem hiding this comment.
Suggested change
| import { | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import { |
There was a problem hiding this comment.
license-eye has totally checked 793 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 731 | 16 | 46 | 0 |
Click to see the invalid file list
- src/components/custom-aggrid/custom-aggrid-filters/custom-aggrid-filter.type.ts
- src/components/custom-aggrid/custom-aggrid.type.ts
- src/components/diagrams/diagram.type.ts
- src/components/diagrams/use-diagram.ts
- src/components/dialogs/limits/limits.type.ts
- src/components/dialogs/parameters/dynamicsimulation/dynamic-simulation.type.ts
- src/components/dialogs/parameters/sensi/shared-functions.ts
- src/components/dialogs/parameters/voltageinit/voltage-init.type.ts
- src/components/graph/util/shared-functions.ts
- src/components/result-view-tab.type.ts
- src/components/results/common/filter.type.ts
- src/components/results/securityanalysis/security-analysis-columns-definition.ts
- src/redux/actions-fields.ts
- src/redux/actions.type.ts
- src/redux/app-state.type.ts
- src/redux/reducer.type.ts
| @@ -0,0 +1,19 @@ | |||
| export enum ViewState { | |||
There was a problem hiding this comment.
Suggested change
| export enum ViewState { | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| export enum ViewState { |
| @@ -0,0 +1,53 @@ | |||
| import { useDispatch } from 'react-redux'; | |||
There was a problem hiding this comment.
Suggested change
| import { useDispatch } from 'react-redux'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import { useDispatch } from 'react-redux'; |
| @@ -0,0 +1,19 @@ | |||
| export enum ViewState { | |||
There was a problem hiding this comment.
Suggested change
| export enum ViewState { | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| export enum ViewState { |
| @@ -0,0 +1,53 @@ | |||
| import { useDispatch } from 'react-redux'; | |||
There was a problem hiding this comment.
Suggested change
| import { useDispatch } from 'react-redux'; | |
| /* | |
| * This Source Code Form is subject to the terms of the Mozilla Public | |
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| */ | |
| import { useDispatch } from 'react-redux'; |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.