gridsuite · sBouzols · Feb 18, 2025
diff --git a/src/components/diagrams/singleLineDiagram/single-line-diagram-content.tsx b/src/components/diagrams/singleLineDiagram/single-line-diagram-content.tsx
@@ -210,11 +210,14 @@ function SingleLineDiagramContent(props: SingleLineDiagramContentProps) {
     const handleBreakerClick: OnBreakerCallbackType = useCallback(
         // switchElement should be SVGElement, this will be fixed once https://github.com/powsybl/powsybl-network-viewer/pull/106/ is merged
         (breakerId, newSwitchState, switchElement: any) => {
+            if (!currentNode) {
+                return;
+            }
             if (!modificationInProgress) {
                 setModificationInProgress(true);
                 setLocallySwitchedBreaker(switchElement?.id);
 
-                updateSwitchState(studyUuid, currentNode?.id, breakerId, newSwitchState).catch((error) => {
+                updateSwitchState(studyUuid, currentNode.id, breakerId, newSwitchState).catch((error) => {
                     console.error(error.message);
                     setErrorMessage(error.message);
                 });
@@ -285,6 +288,9 @@ function SingleLineDiagramContent(props: SingleLineDiagramContentProps) {
 
     const removeEquipment = useCallback(
         (equipmentType: string, equipmentId: string) => {
+            if (!currentNode?.id) {
+                return;
+            }
             deleteEquipment(studyUuid, currentNode?.id, equipmentType, equipmentId, undefined).catch((error) => {
                 snackError({
                     messageTxt: error.message,
@@ -298,10 +304,13 @@ function SingleLineDiagramContent(props: SingleLineDiagramContentProps) {
 
     const handleRunShortcircuitAnalysis = useCallback(
         (busId: string) => {
+            if (!currentNode?.id || !currentRootNetworkUuid) {
+                return;
+            }
             dispatch(setComputingStatus(ComputingType.SHORT_CIRCUIT_ONE_BUS, RunningStatus.RUNNING));
             displayOneBusShortcircuitAnalysisLoader();
             dispatch(setComputationStarting(true));
-            startShortCircuitAnalysis(studyUuid, currentNode?.id, currentRootNetworkUuid, busId)
+            startShortCircuitAnalysis(studyUuid, currentNode.id, currentRootNetworkUuid, busId)
                 .catch((error) => {
                     snackError({
                         messageTxt: error.message,
@@ -317,11 +326,11 @@ function SingleLineDiagramContent(props: SingleLineDiagramContentProps) {
                 });
         },
         [
+            currentNode?.id,
+            currentRootNetworkUuid,
             dispatch,
             displayOneBusShortcircuitAnalysisLoader,
             studyUuid,
-            currentNode?.id,
-            currentRootNetworkUuid,
             snackError,
             resetOneBusShortcircuitAnalysisLoader,
         ]
@@ -344,6 +353,9 @@ function SingleLineDiagramContent(props: SingleLineDiagramContentProps) {
 
     const handleDeleteEquipment = useCallback(
         (equipmentType: EquipmentType | null, equipmentId: string) => {
+            if (!currentNode?.id || !currentRootNetworkUuid) {
+                return;
+            }
             const equipmentEnumType = EQUIPMENT_TYPES[equipmentType as keyof typeof EQUIPMENT_TYPES];
             if (equipmentEnumType !== EQUIPMENT_TYPES.HVDC_LINE) {
                 removeEquipment(equipmentEnumType, equipmentId);

diff --git a/...nts/dialogs/network-modifications/by-filter/by-filter-deletion/by-filter-deletion.type.ts b/...nts/dialogs/network-modifications/by-filter/by-filter-deletion/by-filter-deletion.type.ts
@@ -5,6 +5,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+import { UUID } from 'crypto';
 import { EQUIPMENT_TYPES } from '../../../../utils/equipment-types';
 import { Filter } from '../commons/by-filter.type';
 
@@ -20,8 +21,8 @@ export interface ByFilterDeletionFormData {
 }
 
 export interface ByFilterDeletionDialogProps {
-    studyUuid: string;
-    currentNode: { id: string };
+    studyUuid: UUID;
+    currentNode: { id: UUID };
     editData: ByFilterDeletionEditData;
     isUpdate: boolean;
     editDataFetchStatus: string;

diff --git a/src/components/dialogs/parameters/dynamicsimulation/curve/dialog/model-filter.tsx b/src/components/dialogs/parameters/dynamicsimulation/curve/dialog/model-filter.tsx
@@ -217,6 +217,9 @@ const ModelFilter = forwardRef<GetSelectedVariablesHandle, ModelFilterProps>(
 
         // fetch all associated models and variables for study
         useEffect(() => {
+            if (!studyUuid) {
+                return;
+            }
             fetchDynamicSimulationModels(studyUuid).then((models: DynamicSimulationModelBack[]) => {
                 setAllModels(
                     models.map((model) => ({

diff --git a/src/components/dialogs/parameters/non-evacuated-energy/non-evacuated-energy-parameters.tsx b/src/components/dialogs/parameters/non-evacuated-energy/non-evacuated-energy-parameters.tsx
@@ -221,6 +221,9 @@ export const NonEvacuatedEnergyParameters: FunctionComponent<NonEvacuatedEnergyP
     const [nonEvacuatedEnergyParams, setNonEvacuatedEnergyParams] = useNonEvacuatedEnergyParameters;
 
     const resetNonEvacuatedEnergyParameters = useCallback(() => {
+        if (!studyUuid) {
+            return;
+        }
         setNonEvacuatedEnergyParameters(studyUuid, emptyFormData).catch((error) => {
             snackError({
                 messageTxt: error.message,
@@ -250,6 +253,9 @@ export const NonEvacuatedEnergyParameters: FunctionComponent<NonEvacuatedEnergyP
 
     const onSubmit = useCallback(
         (newParams: NonEvacuatedEnergyParametersForm) => {
+            if (!studyUuid) {
+                return;
+            }
             setNonEvacuatedEnergyParameters(studyUuid, formatNewParams(newParams, true))
                 .then(() => {
                     setNonEvacuatedEnergyParams(formatNewParams(newParams, false));

diff --git a/src/components/dialogs/parameters/sensi/sensitivity-analysis-parameters.tsx b/src/components/dialogs/parameters/sensi/sensitivity-analysis-parameters.tsx
@@ -147,6 +147,9 @@ export const SensitivityAnalysisParameters: FunctionComponent<SensitivityAnalysi
     const [sensitivityAnalysisParams, setSensitivityAnalysisParams] = useState(params);
 
     const resetSensitivityAnalysisParameters = useCallback(() => {
+        if (!studyUuid) {
+            return;
+        }
         setSensitivityAnalysisParameters(studyUuid, null).catch((error) => {
             snackError({
                 messageTxt: error.message,
@@ -225,7 +228,7 @@ export const SensitivityAnalysisParameters: FunctionComponent<SensitivityAnalysi
         (row: any, arrayFormName: SubTabsValues, index: number) => {
             // TODO: not easy to fix any here since values[SubTabsValues] have each time different type which causes problems with "filter"
             // "none of those signatures are compatible with each other
-            if (!currentNode || !currentRootNetworkUuid) {
+            if (!studyUuid || !currentNode?.id || !currentRootNetworkUuid) {
                 return;
             }
             setLaunchLoader(true);
@@ -250,7 +253,7 @@ export const SensitivityAnalysisParameters: FunctionComponent<SensitivityAnalysi
                     });
                 });
         },
-        [snackError, studyUuid, currentRootNetworkUuid, formatFilteredParams, setValue, getResultCount, currentNode]
+        [snackError, studyUuid, currentRootNetworkUuid, formatFilteredParams, setValue, getResultCount, currentNode?.id]
     );
 
     const fromSensitivityAnalysisParamsDataToFormValues = useCallback(
@@ -442,6 +445,9 @@ export const SensitivityAnalysisParameters: FunctionComponent<SensitivityAnalysi
     }, [onChangeParams, getValues]);
     const onSubmit = useCallback(
         (newParams: SensitivityAnalysisParametersFormSchema) => {
+            if (!studyUuid) {
+                return;
+            }
             setIsSubmitAction(true);
             setSensitivityAnalysisParameters(studyUuid, formatNewParams(newParams))
                 .then(() => {

diff --git a/src/components/dialogs/parameters/short-circuit-parameters.tsx b/src/components/dialogs/parameters/short-circuit-parameters.tsx
@@ -193,6 +193,9 @@ export const ShortCircuitParameters: FunctionComponent<ShortCircuitParametersPro
     // submit the new parameters
     const onSubmit = useCallback(
         (newParams: ShortCircuitParametersFormProps) => {
+            if (!studyUuid) {
+                return;
+            }
             const oldParams = shortCircuitParams;
             setShortCircuitParameters(studyUuid, {
                 ...prepareDataToSend(shortCircuitParams, newParams),

diff --git a/src/components/dialogs/parameters/voltageinit/voltage-init-parameters.tsx b/src/components/dialogs/parameters/voltageinit/voltage-init-parameters.tsx
@@ -72,6 +72,9 @@ export const VoltageInitParameters = ({
     }, []);
 
     const resetVoltageInitParameters = useCallback(() => {
+        if (!studyUuid) {
+            return;
+        }
         updateVoltageInitParameters(studyUuid, {
             applyModifications: DEFAULT_GENERAL_APPLY_MODIFICATIONS,
             computationParameters: null,
@@ -105,6 +108,9 @@ export const VoltageInitParameters = ({
 
     const onSubmit = useCallback(
         (newParams: VoltageInitParametersForm) => {
+            if (!studyUuid) {
+                return;
+            }
             updateVoltageInitParameters(studyUuid, fromVoltageInitParametersFormToParamValues(newParams))
                 .then(() => {
                     setVoltageInitParams(fromVoltageInitParametersFormToParamValues(newParams));

diff --git a/src/components/dialogs/restore-modification-dialog.tsx b/src/components/dialogs/restore-modification-dialog.tsx
@@ -4,7 +4,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
-import { useEffect, useState } from 'react';
+import { useCallback, useEffect, useState } from 'react';
 import { FormattedMessage, useIntl } from 'react-intl';
 import {
     Button,
@@ -73,24 +73,30 @@ const RestoreModificationDialog = ({ open, onClose, modifToRestore }: RestoreMod
 
     const { computeLabel } = useModificationLabelComputer();
 
-    const handleClose = () => {
+    const handleClose = useCallback(() => {
         setSelectedItems([]);
         onClose();
-    };
+    }, [onClose]);
 
-    const handleDelete = () => {
+    const handleDelete = useCallback(() => {
+        if (!studyUuid || !currentNode?.id) {
+            return;
+        }
         const selectedModificationsUuidsToDelete = selectedItems.map((item) => item.uuid);
         setOpenDeleteConfirmationPopup(false);
         deleteModifications(studyUuid, currentNode?.id, selectedModificationsUuidsToDelete);
         handleClose();
-    };
+    }, [currentNode?.id, handleClose, selectedItems, studyUuid]);
 
-    const handleRestore = () => {
+    const handleRestore = useCallback(() => {
+        if (!studyUuid || !currentNode?.id) {
+            return;
+        }
         const selectedModificationsUuidToRestore = selectedItems.map((item) => item.uuid);
 
-        restoreModifications(studyUuid, currentNode?.id, selectedModificationsUuidToRestore);
+        restoreModifications(studyUuid, currentNode.id, selectedModificationsUuidToRestore);
         handleClose();
-    };
+    }, [currentNode?.id, handleClose, selectedItems, studyUuid]);
 
     useEffect(() => {
         setStashedModifications(modifToRestore);

diff --git a/src/components/graph/menus/network-modification-node-editor.tsx b/src/components/graph/menus/network-modification-node-editor.tsx
@@ -530,7 +530,7 @@ const NetworkModificationNodeEditor = () => {
     );
 
     const dofetchNetworkModificationsToRestore = useCallback(() => {
-        if (currentNode?.type !== 'NETWORK_MODIFICATION') {
+        if (!studyUuid || currentNode?.type !== 'NETWORK_MODIFICATION') {
             return;
         }
         setLaunchLoader(true);
@@ -559,7 +559,7 @@ const NetworkModificationNodeEditor = () => {
 
     const dofetchNetworkModifications = useCallback(() => {
         // Do not fetch modifications on the root node
-        if (currentNode?.type !== 'NETWORK_MODIFICATION') {
+        if (!studyUuid || currentNode?.type !== 'NETWORK_MODIFICATION') {
             return;
         }
         setLaunchLoader(true);
@@ -691,8 +691,11 @@ const NetworkModificationNodeEditor = () => {
     }, []);
 
     const doDeleteModification = useCallback(() => {
+        if (!studyUuid || !currentNode?.id) {
+            return;
+        }
         const selectedModificationsUuid = selectedItems.map((item) => item.uuid);
-        stashModifications(studyUuid, currentNode?.id, selectedModificationsUuid)
+        stashModifications(studyUuid, currentNode.id, selectedModificationsUuid)
             .then(() => {
                 //if one of the deleted element was in the clipboard we invalidate the clipboard
                 if (
@@ -843,7 +846,7 @@ const NetworkModificationNodeEditor = () => {
     const commit = useCallback(
         ({ source, destination }: DropResult) => {
             setIsDragging(false);
-            if (!currentNode?.id || !destination || source.index === destination.index) {
+            if (!studyUuid || !currentNode?.id || !destination || source.index === destination.index) {
                 return;
             }
             const res = [...modifications];

diff --git a/src/components/graph/menus/node-editor.tsx b/src/components/graph/menus/node-editor.tsx
@@ -16,6 +16,7 @@ import { updateTreeNode } from '../../../services/study/tree-subtree';
 import { Box } from '@mui/material';
 import { AppState } from '../../../redux/reducer';
 import { Theme } from '@mui/material/styles';
+import { useCallback } from 'react';
 
 const styles = {
     paper: (theme: Theme) => ({
@@ -40,18 +41,24 @@ const NodeEditor = () => {
         dispatch(setModificationsDrawerOpen(false));
     };
 
-    const changeNodeName = (newName: string) => {
-        updateTreeNode(studyUuid, {
-            id: currentTreeNode?.id,
-            type: currentTreeNode?.type,
-            name: newName,
-        }).catch((error) => {
-            snackError({
-                messageTxt: error.message,
-                headerId: 'NodeUpdateError',
+    const changeNodeName = useCallback(
+        (newName: string) => {
+            if (!studyUuid || !currentTreeNode?.id) {
+                return;
+            }
+            updateTreeNode(studyUuid, {
+                id: currentTreeNode?.id,
+                type: currentTreeNode?.type,
+                name: newName,
+            }).catch((error) => {
+                snackError({
+                    messageTxt: error.message,
+                    headerId: 'NodeUpdateError',
+                });
             });
-        });
-    };
+        },
+        [currentTreeNode?.id, currentTreeNode?.type, snackError, studyUuid]
+    );
 
     return (
         <Box sx={styles.paper}>

diff --git a/src/components/graph/menus/switch-network-modification-active.tsx b/src/components/graph/menus/switch-network-modification-active.tsx
@@ -31,7 +31,10 @@ export const SwitchNetworkModificationActive = (props: SwitchNetworkModification
 
     const updateModification = useCallback(
         (activated: boolean) => {
-            setModificationActivated(studyUuid, currentNode?.id, modificationUuid, activated)
+            if (!studyUuid || !currentNode?.id) {
+                return;
+            }
+            setModificationActivated(studyUuid, currentNode.id, modificationUuid, activated)
                 .catch((err) => {
                     snackError({ messageTxt: err.message, messageId: 'networkModificationActivationError' });
                 })

diff --git a/src/components/menus/bus-menu.tsx b/src/components/menus/bus-menu.tsx
@@ -84,6 +84,9 @@ export const BusMenu: FunctionComponent<BusMenuProps> = ({
     );
 
     useEffect(() => {
+        if (!studyUuid || !currentNode?.id || !currentRootNetworkUuid) {
+            return;
+        }
         fetchNetworkElementInfos(
             studyUuid,
             currentNode?.id,
@@ -121,12 +124,15 @@ export const BusMenu: FunctionComponent<BusMenuProps> = ({
     );
 
     const handleClickTrip = useCallback(() => {
+        if (!studyUuid || !currentNode?.id) {
+            return;
+        }
         onClose();
         if (setModificationInProgress !== undefined) {
             setModificationInProgress(true);
         }
         const equipmentInfos = { id: busId };
-        tripEquipment(studyUuid, currentNode?.id, equipmentInfos).catch((error) => {
+        tripEquipment(studyUuid, currentNode.id, equipmentInfos).catch((error) => {
             snackError({
                 messageTxt: error.message,
                 headerId: 'UnableToTripBusbarSection',