Update Abstract Filter Argument spec to include @matches spec
#1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmark
force-pushed
the
add_spec_for_matches
branch
2 times, most recently
from
3de3a0f to
ea93031
Compare
magicmark
force-pushed
the
add_spec_for_matches
branch
from
ea93031 to
29c608e
Compare
magicmark
commented
Jan 7, 2026
| TODO: handle the following case | ||
|
|
||
| allPetsConnection @matches { | ||
| ... on ConnectionType { pageInfo { } } # Fragment on the Connection type itself |
Contributor
Author
There was a problem hiding this comment.
is this worth trying to support? or should this just be rejected when using @matches? pretty edge casey...i'm inclined to say the latter.
Member
There was a problem hiding this comment.
I think intermediate fragments should be explicitly rejected. No “spooky action at a distance” for this.
magicmark
force-pushed
the
add_spec_for_matches
branch
from
6d0f276 to
a5f00ff
Compare
magicmark
force-pushed
the
add_spec_for_matches
branch
from
a5f00ff to
513cab0
Compare
Member
|
I’m unsure if separate or same spec makes sense. Maybe same since you want to encourage adoption of both together? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @benjie still a wip but enough to show some progress.
I'll do my best to keep the built version of the specs updated here as a preview:
(this will not be the canonical urls of the final specs as discussed elsewhere; the goal is to publish to a *.graphql.org domain)
Question
29c608e0is an older version of this PR that combines them into a single spec.@limitTypesmay be useful without@matches, but since they're so closely related, I could see it making sense to publish a single document. Thoughts?