Support subclasses of datetime, date, time #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necaris
approved these changes
May 17, 2023
|
Thanks for the approval @necaris! It looks like the pipeline (including other PRs) is having some issues with Poetry. Is there anything you'd like me to to fix up the PR, or will you just merge it when you get a chance to cut the next version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
Users should be able to subclass datetimes and still have their datetime converted to the proper Graphene type.
I wanted to apply the
issubclasslogic to all types, but I'm holding off since my main goal is to fix compatibility with date mocking libraries like Freezegun.Testing
I ran
poetry run pytestlocally with all 40 tests passing.