Handle request retry or re-routing in middleware.afterFilters #100
Open
bilouw wants to merge 1 commit intographiti-api:masterfrom
Open
Handle request retry or re-routing in middleware.afterFilters #100bilouw wants to merge 1 commit intographiti-api:masterfrom
bilouw wants to merge 1 commit intographiti-api:masterfrom
Conversation
…t retry or re-rerouting request)
|
I have a similar use case. What are your thoughts on this PR @richmolj? |
Collaborator
Author
|
Hi ! I use this feat on my fork since many month now, it seems to work pretty good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
Problem: I recently wanted to handle refresh token. My goal was to catch 401 response, get a new token, then retry the request that failed. However, there is no way to modify the response in the middleware.afterFilters function (to return the successfully response instead of the failed one).
Solution: I added a variable to MiddlewareStack Class named "newResponse: Response | null". If this variable is set in middleware.afterFilters function, it will be used as the new response instead of the original response passed to the middleware. I also added the requestOptions, so we can have all the information about the request that failed, to retry it for example. This way, we can handle retry request or re-routing in middleware.afterFilters.
Example - Catch 401 error, get new token then retry the request that failed:
Don't hesitate to tell me if you think about better variable naming or better code implementation.