Copilot/add error logging for html generation#687
Merged
KrzysztofPajak merged 4 commits intodevelopfrom Apr 29, 2026
Merged
Conversation
…rvice Agent-Logs-Url: https://github.com/grandnode/grandnode2/sessions/53809890-623e-4f82-b022-b85ca5e43b88 Co-authored-by: KrzysztofPajak <16772986+KrzysztofPajak@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds error logging around Razor view rendering and HTML-to-PDF generation to improve diagnosability when HTML generation or PDF parsing fails.
Changes:
- Inject
ILogger<T>intoViewRenderServiceand log rendering failures with partial HTML length. - Inject
ILogger<T>intoHtmlToPdfServiceand log exceptions during PDF generation for orders and shipment slips.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Web/Grand.Web.Common/ViewRender/ViewRenderService.cs | Adds ILogger<ViewRenderService> and logs exceptions thrown by RenderAsync. |
| src/Business/Grand.Business.Common/Services/Pdf/HtmlToPdfService.cs | Adds ILogger<HtmlToPdfService> and logs exceptions during PDF generation from rendered HTML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ce.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ce.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
KrzysztofPajak
deleted the
copilot/add-error-logging-for-html-generation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.