[jsonnet]: allow overriding the generator workload#6712
[jsonnet]: allow overriding the generator workload#6712zalegrala wants to merge 2 commits intografana:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Jsonnet microservices deployment for the metrics generator to make the “workload” (controller) referenced by the Service, VPA, and PDB overridable via an overlay, instead of being hard-wired to a specific controller object.
Changes:
- Introduces a hidden
tempo_metrics_generator_workloadfield (defaulting to the generator StatefulSet) and switches Service/VPA/PDB generation to reference it. - Updates
operations/jsonnet-compiled/jsonnetfile.lock.jsonto newer pinned commits forgithub.com/grafana/jsonnet-libs.gitdependencies.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| operations/jsonnet/microservices/generator.libsonnet | Adds an overridable “workload” reference and uses it for Service/VPA/PDB generation. |
| operations/jsonnet-compiled/jsonnetfile.lock.json | Bumps pinned commit versions for Jsonnet library dependencies used by the compiled examples. |
b032d4b to
26b802c
Compare
There was a problem hiding this comment.
Pull request overview
Enables downstream Jsonnet overlays to override which generator controller object is used when generating the Service, Vertical Pod Autoscaler (VPA), and Pod Disruption Budget (PDB) for the metrics-generator microservice.
Changes:
- Introduces a hidden
tempo_metrics_generator_workloadfield as the canonical controller reference for downstream resources. - Switches the generator Service, VPA, and PDB to reference
tempo_metrics_generator_workloadinstead of hard-coding a specific controller.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Tempo Jsonnet microservices generator component to make the “workload” (controller object) that the Service, Vertical Pod Autoscaler (VPA), and Pod Disruption Budget (PDB) are derived from overridable via a single hidden field, enabling downstream overlays/mixins to switch the targeted controller without rewriting those dependent resources.
Changes:
- Add a hidden helper field
tempo_metrics_generator_workload::defaulting to the generator StatefulSet. - Update generator Service/VPA/PDB generation to reference
tempo_metrics_generator_workloadinstead of a hard-coded controller.
What this PR does:
Allow overriding the workload for VPA, PDB and SVC on the generator.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]