Skip to content

[jsonnet]: allow overriding the generator workload#6712

Closed
zalegrala wants to merge 2 commits intografana:mainfrom
zalegrala:tempoMetricsgeneratorWorkloadReference
Closed

[jsonnet]: allow overriding the generator workload#6712
zalegrala wants to merge 2 commits intografana:mainfrom
zalegrala:tempoMetricsgeneratorWorkloadReference

Conversation

@zalegrala
Copy link
Copy Markdown
Contributor

What this PR does:

Allow overriding the workload for VPA, PDB and SVC on the generator.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copilot AI review requested due to automatic review settings March 17, 2026 15:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Jsonnet microservices deployment for the metrics generator to make the “workload” (controller) referenced by the Service, VPA, and PDB overridable via an overlay, instead of being hard-wired to a specific controller object.

Changes:

  • Introduces a hidden tempo_metrics_generator_workload field (defaulting to the generator StatefulSet) and switches Service/VPA/PDB generation to reference it.
  • Updates operations/jsonnet-compiled/jsonnetfile.lock.json to newer pinned commits for github.com/grafana/jsonnet-libs.git dependencies.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
operations/jsonnet/microservices/generator.libsonnet Adds an overridable “workload” reference and uses it for Service/VPA/PDB generation.
operations/jsonnet-compiled/jsonnetfile.lock.json Bumps pinned commit versions for Jsonnet library dependencies used by the compiled examples.

Comment thread operations/jsonnet-compiled/jsonnetfile.lock.json Outdated
Comment thread operations/jsonnet/microservices/generator.libsonnet Outdated
@zalegrala zalegrala force-pushed the tempoMetricsgeneratorWorkloadReference branch from b032d4b to 26b802c Compare March 17, 2026 15:15
@zalegrala zalegrala marked this pull request as ready for review March 17, 2026 15:33
Copilot AI review requested due to automatic review settings March 17, 2026 15:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables downstream Jsonnet overlays to override which generator controller object is used when generating the Service, Vertical Pod Autoscaler (VPA), and Pod Disruption Budget (PDB) for the metrics-generator microservice.

Changes:

  • Introduces a hidden tempo_metrics_generator_workload field as the canonical controller reference for downstream resources.
  • Switches the generator Service, VPA, and PDB to reference tempo_metrics_generator_workload instead of hard-coding a specific controller.

Comment thread operations/jsonnet/microservices/generator.libsonnet Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 27, 2026 20:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Tempo Jsonnet microservices generator component to make the “workload” (controller object) that the Service, Vertical Pod Autoscaler (VPA), and Pod Disruption Budget (PDB) are derived from overridable via a single hidden field, enabling downstream overlays/mixins to switch the targeted controller without rewriting those dependent resources.

Changes:

  • Add a hidden helper field tempo_metrics_generator_workload:: defaulting to the generator StatefulSet.
  • Update generator Service/VPA/PDB generation to reference tempo_metrics_generator_workload instead of a hard-coded controller.

@zalegrala zalegrala closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants