chore(grafana controller): Merge startup sync #2013
+220
−457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
force-pushed
the
chore_merge_startup_sync
branch
3 times, most recently
from
ad90d46 to
042499f
Compare
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
|
Spotted some typing improvements I could make before I put this up for review. |
Baarsgaard
force-pushed
the
chore_merge_startup_sync
branch
from
042499f to
d5c4073
Compare
Baarsgaard
force-pushed
the
chore_merge_startup_sync
branch
2 times, most recently
from
0b2e46c to
31af353
Compare
theSuess
reviewed
May 26, 2025
Baarsgaard
force-pushed
the
chore_merge_startup_sync
branch
from
31af353 to
c0eb53b
Compare
Baarsgaard
force-pushed
the
chore_merge_startup_sync
branch
from
c0eb53b to
528c04e
Compare
|
That dashboard indeed references the old metrics, I'll post a picture of the updated dashboard. |
Baarsgaard
force-pushed
the
chore_merge_startup_sync
branch
from
528c04e to
c8d63fe
Compare
|
Old: New: There is less data, but I removed the extra sync duration displays and extended the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR related to #1990 which merges all
startupSyncfunctions into the Grafana Controller.Also fixes the bug that non-leader instances runs startup Sync without being elected.
The dashboard was updated to only display the new startup sync metric and use the new
instance_namespacelabel for in the legend forCR Reconciles.