Working version with bzlmod, rules_kotlin v2, rules_android (with my PR fork)#204
Open
pswaminathan wants to merge 6 commits intograb:masterfrom
Open
Working version with bzlmod, rules_kotlin v2, rules_android (with my PR fork)#204pswaminathan wants to merge 6 commits intograb:masterfrom
pswaminathan wants to merge 6 commits intograb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't apply cleanly, but I figured I would at least show my work. I may try rebasing on master, but here is generally what I have:
rules_java,rules_kotlinwithout the prefix,rules_androidrules_kotlinchange broke reflection-based worker classes. I switched those to use KSP and it all workedbazel_common_mavenfor maven depsThis works as a dependency. You may also need (what we have in our main repository's MODULE.bazel:
This
rules_androidcommit includes the databinding PR work that exposes the correct targets to databinding_exec.jar (i.e. obsoletes #200). Additionally, we have:Basically we took the android_tools jar from here and put it on a CDN. Bazel's
override_repomakes it very straightforward to use this version without having to further patchrules_android