Bazel 8 migration - Patch databinding output name to add double dash as suffix#201
Closed
edwin-grabtaxi wants to merge 1 commit intomigration/bazel_8_main_branchfrom
Closed
Conversation
edwin-grabtaxi
requested review from
adarsh-grabtaxi,
arnav-grabtaxi,
arunsampathkumar-grabtaxi,
minkuanlim-grabtaxi and
vanminh-grabtaxi
as code owners
edwin-grabtaxi
deleted the
migration/bazel_8_patch_databinding_output
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch... i'm not really sure, it seems that there's a convention written in the tool to use double dash for the databinding's compiled metadatas.
Without double dash, the build facing error e.g.
'tests/android/library/databinding/android_library_sample/bin-files/com.grab.test.lib-br.bin' was not created