-
Notifications
You must be signed in to change notification settings - Fork 20
fix: support auto-generating agent path from name #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 5a05874 in 36 seconds. Click for details.
- Reviewed
108lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/components/CreateAgentDialog.tsx:87
- Draft comment:
Before computing the default fork_command, ensure that the workspace path is auto-generated if empty. Currently, processedData.path may be an empty string, causing fork_command to miss the auto-generated value. Consider setting: processedData.path = data.path.trim() ? data.path :./${slugifyName(data.name)}; before using it in fork_command and when submitting agentData. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_kmM8GDxlOw31Polf
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed e12af4f in 1 minute and 40 seconds. Click for details.
- Reviewed
48lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/components/CreateAgentDialog.tsx:29
- Draft comment:
Removed the client-side slugifyName function. Ensure the backend reliably auto-generates a valid agent_path when none is provided. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. src/components/CreateAgentDialog.tsx:51
- Draft comment:
Updated onAgentCreated type to return CreateAgentResponse, which now includes agent_path. Confirm that the API always returns this field. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm that the API always returns a specific field. This falls under asking the author to confirm their intention or to ensure behavior, which is against the rules.
3. src/components/CreateAgentDialog.tsx:106
- Draft comment:
Now using response.agent_path directly for setting the selected agent's path. Verify that the server returns a proper agent_path even when the workspace path isn’t manually specified. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_UgK7ygyixXe6I3Xe
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 848b334 in 1 minute and 31 seconds. Click for details.
- Reviewed
90lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/components/CreateAgentDialog.tsx:181
- Draft comment:
Workspace Settings was moved into Advanced Options. Make sure hiding the 'path' field by default is intended, as users may overlook the auto-generation behavior. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. src/components/CreateAgentDialog.tsx:188
- Draft comment:
Consider auto-populating the 'path' field based on the 'name' field to better reflect the auto-generation feature. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment suggests a UI enhancement to auto-populate the field, but this seems unnecessary since: 1) The field is intentionally optional 2) The auto-generation happens server-side 3) Users may want to specify their own path 4) The current UX clearly communicates that the field will be auto-generated if left empty. Auto-populating might actually make the UX worse by forcing users to delete the auto-populated value if they want to trigger server-side generation. I could be wrong about where the auto-generation happens - there might be client-side code I'm missing. Also, some users might prefer seeing the generated path before submission. Even if the auto-generation is client-side, the current UX is clear and functional. Auto-populating would add complexity without clear benefit and might make the UX worse for users who want to use server-side generation. The comment should be deleted. The current UX clearly communicates the auto-generation feature, and auto-populating the field could actually worsen the user experience.
Workflow ID: wflow_YUiFnO11rfP4hvGK
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Depends on gptme/gptme#646
Important
Make
pathoptional inCreateAgentRequest, auto-generate if missing, and updateCreateAgentResponseto includeagent_path.pathinCreateAgentRequestis now optional and auto-generated if not provided inCreateAgentDialog.tsx.agent_pathadded toCreateAgentResponseand used to update selected agent's path.handleSubmit()inCreateAgentDialog.tsxno longer requirespathto be non-empty.createAgent()inapi.tsupdated to acceptCreateAgentRequesttype.CreateAgentDialog.tsx.This description was created by
for 848b334. You can customize this summary. It will automatically update as commits are pushed.