feat(webui): prefill author selection when bulk editing books#1053
Open
noaione wants to merge 1 commit intogotson:masterfrom
Open
feat(webui): prefill author selection when bulk editing books#1053noaione wants to merge 1 commit intogotson:masterfrom
noaione wants to merge 1 commit intogotson:masterfrom
Conversation
noaione
force-pushed
the
feat/bulk-author-thing
branch
from
e27c76e to
79cf808
Compare
noaione
force-pushed
the
feat/bulk-author-thing
branch
from
79cf808 to
aea4ad3
Compare
noaione
force-pushed
the
feat/bulk-author-thing
branch
from
aea4ad3 to
df22609
Compare
noaione
force-pushed
the
feat/bulk-author-thing
branch
from
df22609 to
314441d
Compare
noaione
force-pushed
the
feat/bulk-author-thing
branch
from
314441d to
dd74d74
Compare
noaione
force-pushed
the
feat/bulk-author-thing
branch
from
dd74d74 to
5b56f20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation is that if we select multiple books like this:
It will keep the whole thing empty.
This PR should make the selection prefilled with what has been added.
komga_author_prefill_bulk_demo.mp4
Some problems need addressing:
As an example, two books have the following filled in:
Writer,PencillerWriterCurrently, the form will haveWriterandPencillerprefilled. I don't know if you like this behaviour or prefer to leave thePencillerempty.Changed to basically get the intersection of many books for each roles, so only authors that exist on multiple books will be prefilled on a roles.