Skip to content

Refactor Mockito tests in InMobi adapter #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copybara-service wants to merge 1 commit into from
Closed

Refactor Mockito tests in InMobi adapter #1105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...s/inmobi/inmobi/src/test/kotlin/com/google/ads/mediation/inmobi/InMobiAdapterUtilsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import org.mockito.kotlin.any
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import org.mockito.kotlin.never
import org.mockito.kotlin.stub
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever

@RunWith(AndroidJUnit4::class)
class InMobiAdapterUtilsTest {
Expand Down Expand Up @@ -281,9 +281,11 @@ class InMobiAdapterUtilsTest {
}

private fun setupMobiNativeAdWrapper(): Unit {
whenever(inMobiNativeWrapper.adCtaText) doReturn ("SomeCtaText")
whenever(inMobiNativeWrapper.adDescription) doReturn ("AdDescription")
whenever(inMobiNativeWrapper.adIconUrl) doReturn ("http://www.example.com/docs/resource1.html")
whenever(inMobiNativeWrapper.adTitle) doReturn ("adTitle")
inMobiNativeWrapper.stub {
on { adCtaText } doReturn ("SomeCtaText")
on { adDescription } doReturn ("AdDescription")
on { adIconUrl } doReturn ("http://www.example.com/docs/resource1.html")
on { adTitle } doReturn ("adTitle")
}
}
}
31 changes: 17 additions & 14 deletions ...mobi/inmobi/src/test/kotlin/com/google/ads/mediation/inmobi/InMobiMediationAdapterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import org.mockito.kotlin.argumentCaptor
import org.mockito.kotlin.doAnswer
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import org.mockito.kotlin.stub
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever

Expand Down Expand Up @@ -88,7 +89,7 @@ class InMobiMediationAdapterTest {
serverParameters.putString(InMobiAdapterUtils.KEY_PLACEMENT_ID, "67890")

setupMockAdConfiguration(bannerAdConfiguration)
whenever(bannerAdConfiguration.adSize).thenReturn(originalBannerSize)
bannerAdConfiguration.stub { on { getAdSize() } doReturn originalBannerSize }
whenever(
mediationUtils.findClosestSize(
org.mockito.kotlin.eq(context),
Expand All @@ -115,9 +116,11 @@ class InMobiMediationAdapterTest {
}

private fun setupMockAdConfiguration(config: MediationAdConfiguration) {
whenever(config.context).thenReturn(context)
whenever(config.serverParameters).thenReturn(serverParameters)
whenever(config.watermark).thenReturn(TEST_WATERMARK)
config.stub {
on { getContext() } doReturn context
on { getServerParameters() } doReturn serverParameters
on { watermark } doReturn TEST_WATERMARK
}
}

@Test
Expand Down Expand Up @@ -147,7 +150,7 @@ class InMobiMediationAdapterTest {
@Test
fun getSDKVersionInfo_ifInMobiSDKVersionIsValid_returnSameVersion() {
// set a valid InMobi SDK version.
whenever(inMobiSdkWrapper.version).thenReturn("10.5.4")
inMobiSdkWrapper.stub { on { version } doReturn "10.5.4" }

val versionInfo = adapter.sdkVersionInfo

Expand All @@ -159,7 +162,7 @@ class InMobiMediationAdapterTest {
@Test
fun getSDKVersionInfo_ifInMobiSDKVersionIsInvalid_returnsZeros() {
// set an invalid InMobi SDK version
whenever(inMobiSdkWrapper.version).thenReturn("10.4")
inMobiSdkWrapper.stub { on { version } doReturn "10.4" }

val versionInfo = adapter.sdkVersionInfo

Expand All @@ -170,7 +173,7 @@ class InMobiMediationAdapterTest {

@Test
fun initialize_ifInMobiSDKInitialized_invokesOnInitializationSucceededCallback() {
whenever(inMobiSdkWrapper.isSDKInitialized).thenReturn(true)
inMobiSdkWrapper.stub { on { isSDKInitialized } doReturn true }

adapter.initialize(context, initializationCompleteCallback, listOf(mediationConfiguration))

Expand All @@ -182,7 +185,7 @@ class InMobiMediationAdapterTest {
whenever(inMobiSdkWrapper.isSDKInitialized).thenReturn(false)
val invalidServerParameters = Bundle()
invalidServerParameters.putString(InMobiAdapterUtils.KEY_ACCOUNT_ID, "")
whenever(mediationConfiguration.serverParameters).thenReturn(invalidServerParameters)
mediationConfiguration.stub { on { getServerParameters() } doReturn invalidServerParameters }
// Create an AdError object so that it can be verified that this object's toString() matches the
// error string that's passed to the initialization callback.
val adError =
Expand All @@ -200,7 +203,7 @@ class InMobiMediationAdapterTest {

@Test
fun initialize_ifInMobiSDKNotInitialized_invokesInitOnInMobiInitializer() {
whenever(inMobiSdkWrapper.isSDKInitialized).thenReturn(false)
inMobiSdkWrapper.stub { on { isSDKInitialized } doReturn false }
whenever(mediationConfiguration.serverParameters).thenReturn(serverParameters)

adapter.initialize(context, initializationCompleteCallback, listOf(mediationConfiguration))
Expand Down Expand Up @@ -254,7 +257,7 @@ class InMobiMediationAdapterTest {

@Test
fun loadBannerAd_invalidBannerSize_invokesFailureCallback() {
whenever(bannerAdConfiguration.adSize).thenReturn(AdSize(350, 100))
bannerAdConfiguration.stub { on { getAdSize() } doReturn AdSize(350, 100) }

adapter.loadBannerAd(bannerAdConfiguration, bannerAdLoadCallback)

Expand Down Expand Up @@ -353,7 +356,7 @@ class InMobiMediationAdapterTest {
val listener = it.arguments[2] as Listener
listener.onInitializeSuccess()
}
whenever(bannerAdConfiguration.bidResponse).thenReturn(biddingToken)
bannerAdConfiguration.stub { on { bidResponse } doReturn biddingToken }

adapter.loadRtbBannerAd(bannerAdConfiguration, bannerAdLoadCallback)

Expand Down Expand Up @@ -459,7 +462,7 @@ class InMobiMediationAdapterTest {
val listener = it.arguments[2] as Listener
listener.onInitializeSuccess()
}
whenever(interstitialAdConfiguration.bidResponse).thenReturn(biddingToken)
interstitialAdConfiguration.stub { on { bidResponse } doReturn biddingToken }

adapter.loadRtbInterstitialAd(interstitialAdConfiguration, interstitialAdLoadCallback)

Expand Down Expand Up @@ -549,7 +552,7 @@ class InMobiMediationAdapterTest {
val listener = it.arguments[2] as Listener
listener.onInitializeSuccess()
}
whenever(rewardedAdConfiguration.bidResponse).thenReturn(biddingToken)
rewardedAdConfiguration.stub { on { bidResponse } doReturn biddingToken }

adapter.loadRtbRewardedAd(rewardedAdConfiguration, rewardedAdLoadCallback)

Expand Down Expand Up @@ -639,7 +642,7 @@ class InMobiMediationAdapterTest {
val listener = it.arguments[2] as Listener
listener.onInitializeSuccess()
}
whenever(nativeAdConfiguration.bidResponse).thenReturn(biddingToken)
nativeAdConfiguration.stub { on { bidResponse } doReturn biddingToken }

adapter.loadRtbNativeAd(nativeAdConfiguration, nativeAdLoadCallback)

Expand Down
11 changes: 7 additions & 4 deletions ...inmobi/src/test/kotlin/com/google/ads/mediation/inmobi/rtb/InMobiRtbInterstitialAdTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import org.mockito.kotlin.argumentCaptor
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import org.mockito.kotlin.never
import org.mockito.kotlin.stub
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever

Expand Down Expand Up @@ -61,8 +62,9 @@ class InMobiRtbInterstitialAdTest {
whenever(interstitialAdConfiguration.bidResponse).thenReturn("BiddingToken")
whenever(inMobiInterstitialWrapper.isReady).thenReturn(true)
whenever(mediationAdLoadCallback.onSuccess(any())).thenReturn(mediationInterstitialAdCallback)
whenever(interstitialAdConfiguration.serverParameters) doReturn
bundleOf(KEY_PLACEMENT_ID to "67890")
interstitialAdConfiguration.stub {
on { getServerParameters() } doReturn bundleOf(KEY_PLACEMENT_ID to "67890")
}

rtbInterstitialAd.loadAd(interstitialAdConfiguration)
rtbInterstitialAd.showAd(context)
Expand All @@ -76,8 +78,9 @@ class InMobiRtbInterstitialAdTest {
.thenReturn(inMobiInterstitialWrapper)
whenever(interstitialAdConfiguration.bidResponse).thenReturn("BiddingToken")
whenever(inMobiInterstitialWrapper.isReady).thenReturn(false)
whenever(interstitialAdConfiguration.serverParameters) doReturn
bundleOf(KEY_PLACEMENT_ID to "67890")
interstitialAdConfiguration.stub {
on { getServerParameters() } doReturn bundleOf(KEY_PLACEMENT_ID to "67890")
}
rtbInterstitialAd.loadAd(interstitialAdConfiguration)
// mimic an ad load.
rtbInterstitialAd.onAdLoadSucceeded(inMobiInterstitialWrapper.inMobiInterstitial, adMetaInfo)
Expand Down
11 changes: 7 additions & 4 deletions ...obi/inmobi/src/test/kotlin/com/google/ads/mediation/inmobi/rtb/InMobiRtbRewardedAdTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import org.mockito.kotlin.any
import org.mockito.kotlin.argumentCaptor
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import org.mockito.kotlin.stub
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever

Expand Down Expand Up @@ -58,8 +59,9 @@ class InMobiRtbRewardedAdTest {
.thenReturn(inMobiRewardedWrapper)
whenever(inMobiRewardedWrapper.isReady).thenReturn(false)
whenever(rewardedAdConfiguration.bidResponse).thenReturn("BiddingToken")
whenever(rewardedAdConfiguration.serverParameters) doReturn
bundleOf(KEY_PLACEMENT_ID to "67890")
rewardedAdConfiguration.stub {
on { getServerParameters() } doReturn bundleOf(KEY_PLACEMENT_ID to "67890")
}

// invoke the create rewardedAd method to get an instance of InMobiRewardedWrapper
rtbRewardedAd.loadAd(rewardedAdConfiguration)
Expand All @@ -79,8 +81,9 @@ class InMobiRtbRewardedAdTest {
.thenReturn(inMobiRewardedWrapper)
whenever(inMobiRewardedWrapper.isReady).thenReturn(true)
whenever(rewardedAdConfiguration.bidResponse).thenReturn("BiddingToken")
whenever(rewardedAdConfiguration.serverParameters) doReturn
bundleOf(KEY_PLACEMENT_ID to "67890")
rewardedAdConfiguration.stub {
on { getServerParameters() } doReturn bundleOf(KEY_PLACEMENT_ID to "67890")
}

// invoke the create rewardedAd method to get an instance of InMobiRewardedWrapper
rtbRewardedAd.loadAd(rewardedAdConfiguration)
Expand Down
13 changes: 9 additions & 4 deletions ...est/kotlin/com/google/ads/mediation/inmobi/waterfall/InMobiWaterfallInterstitialAdTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import org.mockito.kotlin.doReturn
import org.mockito.kotlin.eq
import org.mockito.kotlin.mock
import org.mockito.kotlin.never
import org.mockito.kotlin.stub
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever

Expand Down Expand Up @@ -64,8 +65,10 @@ class InMobiWaterfallInterstitialAdTest {
whenever(inMobiInterstitialWrapper.isReady).thenReturn(true)
whenever(mediationAdLoadCallback.onSuccess(any())).thenReturn(mediationInterstitialAdCallback)
val placementId = 67890L
whenever(interstitialAdConfiguration.serverParameters) doReturn
bundleOf(KEY_ACCOUNT_ID to "accountTest", KEY_PLACEMENT_ID to placementId.toString())
interstitialAdConfiguration.stub {
on { getServerParameters() } doReturn
bundleOf(KEY_ACCOUNT_ID to "accountTest", KEY_PLACEMENT_ID to placementId.toString())
}
waterfallInterstitialAd.loadAd(interstitialAdConfiguration)
verify(inMobiInitializer)
.init(eq(context), eq("accountTest"), initializerListenerCaptor.capture())
Expand All @@ -83,8 +86,10 @@ class InMobiWaterfallInterstitialAdTest {
.thenReturn(inMobiInterstitialWrapper)
whenever(inMobiInterstitialWrapper.isReady).thenReturn(false)
val placementId = 67890L
whenever(interstitialAdConfiguration.serverParameters) doReturn
bundleOf(KEY_ACCOUNT_ID to "accountTest", KEY_PLACEMENT_ID to placementId.toString())
interstitialAdConfiguration.stub {
on { getServerParameters() } doReturn
bundleOf(KEY_ACCOUNT_ID to "accountTest", KEY_PLACEMENT_ID to placementId.toString())
}
waterfallInterstitialAd.loadAd(interstitialAdConfiguration)
verify(inMobiInitializer)
.init(eq(context), eq("accountTest"), initializerListenerCaptor.capture())
Expand Down
13 changes: 9 additions & 4 deletions ...rc/test/kotlin/com/google/ads/mediation/inmobi/waterfall/InMobiWaterfallRewardedAdTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import org.mockito.kotlin.argumentCaptor
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.eq
import org.mockito.kotlin.mock
import org.mockito.kotlin.stub
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever

Expand Down Expand Up @@ -62,8 +63,10 @@ class InMobiWaterfallRewardedAdTest {
.thenReturn(inMobiRewardedWrapper)
whenever(inMobiRewardedWrapper.isReady).thenReturn(false)
val placementId = 67890L
whenever(rewardedAdConfiguration.serverParameters) doReturn
bundleOf(KEY_ACCOUNT_ID to "accountTest", KEY_PLACEMENT_ID to placementId.toString())
rewardedAdConfiguration.stub {
on { getServerParameters() } doReturn
bundleOf(KEY_ACCOUNT_ID to "accountTest", KEY_PLACEMENT_ID to placementId.toString())
}

// invoke the create rewardedAd method to get an instance of InMobiRewardedWrapper
waterfallRewardedAd.loadAd(rewardedAdConfiguration)
Expand All @@ -87,8 +90,10 @@ class InMobiWaterfallRewardedAdTest {
.thenReturn(inMobiRewardedWrapper)
whenever(inMobiRewardedWrapper.isReady).thenReturn(true)
val placementId = 67890L
whenever(rewardedAdConfiguration.serverParameters) doReturn
bundleOf(KEY_ACCOUNT_ID to "accountTest", KEY_PLACEMENT_ID to placementId.toString())
rewardedAdConfiguration.stub {
on { getServerParameters() } doReturn
bundleOf(KEY_ACCOUNT_ID to "accountTest", KEY_PLACEMENT_ID to placementId.toString())
}

// invoke the create rewardedAd method to get an instance of InMobiRewardedWrapper
waterfallRewardedAd.loadAd(rewardedAdConfiguration)
Expand Down
Loading