-
Notifications
You must be signed in to change notification settings - Fork 214
Customize shared context #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
axos88
wants to merge
26
commits into
google:main
Choose a base branch
from
axos88:customize-shared-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it shared context between client and server
…zable as well. Since this is part of the contract between client and server, it is implemented as an option to the service macro.
…needs extraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third and final PR of the solution to #392, and builds on top of #539 and #540.
The diff view will show both PRs, please take a look at the commit view for a clean diff.
This makes it possible to change the shared context sent between client and server, allowing functionality like semi-persistent session data (think http cookies), that is sent by the client, and can be manipulated by the server before sending back, without polluting the trait API.
Take a look at the custom_context example to see how sessions can be implemented, and also how the ClientContext, ServerContext and CustomSharedContext work together.