-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add run_tests.sh
to ffmpeg
#13449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vitaliset
wants to merge
6
commits into
master
Choose a base branch
from
tests_ffmpeg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add run_tests.sh
to ffmpeg
#13449
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c008ebb
add tests to ffmpeg
vitaliset 35c189d
add copyright
vitaliset 42a6701
simplifying avaiable API and adding logic to build if not built
vitaliset fd2da80
Adding TODO comment
vitaliset 3dee1cc
getting rid of if not compile then copile logic
vitaliset b1af8c5
renaming variable
vitaliset File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
#!/bin/bash | ||
# Copyright 2025 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
################################################################################ | ||
|
||
# Usage: bash run_test.sh | ||
# Runs all tests (same as 'make fate') and compiles if not compiled. | ||
|
||
set -e # Exit immediately if any command fails | ||
|
||
FFMPEG_SRC_DIR="/src/ffmpeg" | ||
OUT_DIR="${OUT:-/out}" | ||
|
||
# Executable fuzzer implies built. | ||
if [ ! -d "$OUT_DIR" ]; then | ||
# Output directory does not exist. | ||
# This implies no build has occurred or populated this directory. | ||
IS_LIKELY_BUILT=0 | ||
else | ||
if [ -z "$(ls -A "$OUT_DIR" 2>/dev/null)" ]; then | ||
vitaliset marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# Output directory exists but is empty. | ||
# This implies no build has populated this directory yet. | ||
IS_LIKELY_BUILT=0 | ||
else | ||
# Check specifically for executable files within OUT_DIR or its immediate subdirectories. | ||
first_executable=$(find "$OUT_DIR" -maxdepth 2 -type f -executable -print -quit 2>/dev/null) | ||
|
||
if [ -n "$first_executable" ]; then | ||
# Found executable file(s) in the output directory. | ||
# This suggests a build has already occurred. | ||
IS_LIKELY_BUILT=1 | ||
|
||
else | ||
# $OUT is not empty, but no executables found. Could be intermediate files, logs, corpus, etc. | ||
IS_LIKELY_BUILT=0 | ||
fi | ||
fi | ||
fi | ||
|
||
|
||
if [ "$IS_LIKELY_BUILT" -eq 0 ]; then | ||
echo "==> Project is not likely built. Building..." | ||
bash build.sh # TODO(carlolemos): Check if we get to the same state of | ||
vitaliset marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# us-central1-docker.pkg.dev/oss-fuzz/oss-fuzz-gen/ffmpeg-ofg-cached-address | ||
make -j$(nproc) | ||
|
||
echo "==> Build finished." | ||
fi | ||
|
||
echo "==> Changing to FFmpeg source directory: $FFMPEG_SRC_DIR" | ||
cd "$FFMPEG_SRC_DIR" | ||
|
||
echo "==> Running all FATE tests..." | ||
make fate | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how long does this take to run? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like the current version of the container is broken: https://paste.googleplex.com/4602035483443200 |
||
|
||
echo "==> Test run finished successfully." |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.