[Feature] bind delete_keys parameter on tf_client update_priority #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @cmarlin, Thanks a lot for contributing to Reverb and sorry for the long delay. If you could take a look at the merge conflicts that have developed then I'd be more than happy to accept this PR! Thanks, |
cmarlin
force-pushed
the
fix_delete_keys
branch
from
2f47a22 to
d7b153e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
For sample efficiency approach I need to randomly reevaluate target policy/value and update it.
The client API allow to remove such datas but not the tf_client. As the core functions allow it I suggest to bind parameters.
Thanks,