Fix Warp mouse on Tablet/Trackpad 3D Navigation Scheme#116779
Open
MaxiSanc37 wants to merge 1 commit intogodotengine:masterfrom
Open
Fix Warp mouse on Tablet/Trackpad 3D Navigation Scheme#116779MaxiSanc37 wants to merge 1 commit intogodotengine:masterfrom
MaxiSanc37 wants to merge 1 commit intogodotengine:masterfrom
Conversation
Co-authored-by: kateyvk <kateyvk16@gmail.com>
ea4047f to
44727ca
Compare
Contributor
Author
|
I accidentally created this feature branch from a previous PR feature branch so there's also the code that was changed for that issue: #115915 so the code insertions for that is included as well, do you want me to remove the changes on that file manually and squashing the commits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes_mouse_warp.mp4
(the lag in the video is not reflective of how the engine is running, it's just the windows snipping tool doing some weird cuts on the video).
This fixes #116177 where emulated 3-button navigation (e.g. Alt/Shift + trackpad drag) stopped when the pointer left the 3D viewport. Instead of relying on mouse capture (which hides the cursor), this PR adds an emulated-nav continuation path in Node3DEditorViewport:
Inside-viewport motion still uses the existing _sinput() flow, so behavior remains consistent and avoids double-processing.
Changed files
Testing