Autocompletion: Don't hide certain setters and getters#116776
Open
HolonProduction wants to merge 1 commit intogodotengine:masterfrom
Open
Autocompletion: Don't hide certain setters and getters#116776HolonProduction wants to merge 1 commit intogodotengine:masterfrom
HolonProduction wants to merge 1 commit intogodotengine:masterfrom
Conversation
Co-authored-by: Will Thompson <wjt@endlessaccess.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116717
Fixes #114832
Autocompletion filters out getters and setters to not clutter the list. However the filtering applied hides some important methods: indexed props are not easily accessible in other ways and so their getters and setter should be suggest. Also if a property is internal, we really should not hide its public setters and getters.
Sanity check: Is this the right place for fixing this, it's
core/after all?p_methodsis only used together withp_exclude_from_properties.p_exclude_from_propertiesis not exposed and only used in two places: autocompletion and listing methods for some picker dialog in the editor. So yeah this is a good place to fix this.Due to the very limited audience of the parameter there really is no need for any more finegrained control as suggested in #116717 (comment)
@wjt I added you as co-author, since half of this PR is basically your suggested patch