CI: Pass generate_bundle=yes to apple builders#116772
Open
Repiteo wants to merge 1 commit intogodotengine:masterfrom
Open
CI: Pass generate_bundle=yes to apple builders#116772Repiteo wants to merge 1 commit intogodotengine:masterfrom
generate_bundle=yes to apple builders#116772Repiteo wants to merge 1 commit intogodotengine:masterfrom
Conversation
bruvzg
reviewed
Feb 25, 2026
.github/workflows/macos_builds.yml
Outdated
| dev_mode=yes | ||
| module_text_server_fb_enabled=yes | ||
| "accesskit_sdk_path=${{ github.workspace }}/accesskit-c-0.18.0/" | ||
| generate_bundle=yes |
Member
There was a problem hiding this comment.
Suggested change
| generate_bundle=yes |
.github/workflows/macos_builds.yml
Outdated
Member
There was a problem hiding this comment.
Suggested change
| scons-flags: ${{ env.SCONS_FLAGS }} ${{ matrix.scons-flags }} arch=arm64 vulkan=${{ steps.vulkan-sdk.outputs.VULKAN_ENABLED }} generate_bundle=yes |
Needed to be added on the last build step only.
.github/workflows/macos_builds.yml
Outdated
.github/workflows/macos_builds.yml
Outdated
Comment on lines
100
to
101
Member
There was a problem hiding this comment.
Suggested change
| strip ${{ matrix.bin }} | |
| chmod +x ${{ matrix.bin }} |
.github/workflows/macos_builds.yml
Outdated
Member
There was a problem hiding this comment.
Suggested change
| bin: godot_macos_editor.app/Contents/MacOS/Godot |
Contributor
Author
There was a problem hiding this comment.
Artifact uploads are currently scoped to the bin/ directory; should they be rescoped to <name>.app?
Contributor
Author
There was a problem hiding this comment.
Or are these still within bin/?
.github/workflows/macos_builds.yml
Outdated
Member
There was a problem hiding this comment.
Suggested change
| bin: macos_template.app/Contents/MacOS/godot_macos_release.universal |
Member
There was a problem hiding this comment.
Actually this will be in the ZIP, so not sure how to handle it, might be worth keeping lipo step for tests and delete all except bundle/zip before upload.
Repiteo
force-pushed
the
ci/bundle-apple
branch
3 times, most recently
from
38e3a44 to
d3525a7
Compare
Repiteo
force-pushed
the
ci/bundle-apple
branch
from
d3525a7 to
87aff4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amends the
iOSandmacOSbuilders withgenerate_bundle=yes, which should make the templates produced "feature-complete". I've never built for apple platforms before so I'm flying a bit blind, butiOSshould be fully accounted for at least. FormacOSI'm currently passing the value for both editor and template on both architectures; will likely need further adjustment based on build output