Skip to content

Tidy some things up in modules/jolt_physics#116768

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
mihe:jolt/tidying-up
Feb 26, 2026
Merged

Tidy some things up in modules/jolt_physics#116768
Repiteo merged 1 commit intogodotengine:masterfrom
mihe:jolt/tidying-up

Conversation

@mihe
Copy link
Contributor

@mihe mihe commented Feb 25, 2026

I'm sure I could find many more things to change, but I've had some of these lying around in a branch for months now, waiting for more of these minor changes to pile up, and now seems like a good time to push them.

The changes are as follows:

  1. Moved JoltObject3D::shapes into JoltShapedObject3D instead, since it had no business being there, so just added 16 bytes to every JoltSoftBody3D for no reason.
  2. Have the creation of JPH::EmptyShape just use the constructor rather than going the roundabout way of JPH::EmptyShapeSettings(...).Create().Get().
  3. Moved the recently moved SetBodyActivationListener calls from JoltSpace3D::step into JoltSpace3D::_pre_step and JoltSpace3D::_post_step, where they arguably belong.
  4. Changed JoltContactListener3D::area_soft_body_overlaps to be a LocalVector instead of a HashSet, since we have no need for the deduplication, sorting or lookup that HashSet would offer.

@mihe mihe added this to the 4.x milestone Feb 25, 2026
@mihe mihe requested review from a team as code owners February 25, 2026 16:52
@mihe mihe modified the milestones: 4.x, 4.7 Feb 25, 2026
@Repiteo Repiteo merged commit 5a5a806 into godotengine:master Feb 26, 2026
38 of 40 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 26, 2026

Thanks!

@mihe mihe deleted the jolt/tidying-up branch February 26, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants