Tidy some things up in modules/jolt_physics#116768
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Feb 26, 2026
Merged
Tidy some things up in modules/jolt_physics#116768Repiteo merged 1 commit intogodotengine:masterfrom
modules/jolt_physics#116768Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
akien-mga
approved these changes
Feb 25, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sure I could find many more things to change, but I've had some of these lying around in a branch for months now, waiting for more of these minor changes to pile up, and now seems like a good time to push them.
The changes are as follows:
JoltObject3D::shapesintoJoltShapedObject3Dinstead, since it had no business being there, so just added 16 bytes to everyJoltSoftBody3Dfor no reason.JPH::EmptyShapejust use the constructor rather than going the roundabout way ofJPH::EmptyShapeSettings(...).Create().Get().SetBodyActivationListenercalls fromJoltSpace3D::stepintoJoltSpace3D::_pre_stepandJoltSpace3D::_post_step, where they arguably belong.JoltContactListener3D::area_soft_body_overlapsto be aLocalVectorinstead of aHashSet, since we have no need for the deduplication, sorting or lookup thatHashSetwould offer.