Add Hit Margin Theme Constant for BaseButton#116763
Open
Kazox61 wants to merge 1 commit intogodotengine:masterfrom
Open
Add Hit Margin Theme Constant for BaseButton#116763Kazox61 wants to merge 1 commit intogodotengine:masterfrom
BaseButton#116763Kazox61 wants to merge 1 commit intogodotengine:masterfrom
Conversation
|
|
||
| DrawMode get_draw_mode() const; | ||
|
|
||
| bool has_point(const Point2 &p_point) const override; |
Member
There was a problem hiding this comment.
Suggested change
| bool has_point(const Point2 &p_point) const override; | |
| virtual bool has_point(const Point2 &p_point) const override; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#4338
This adds a Hit Margin Theme Constant for BaseButton.
The only way I found to implement this was by overriding the has_point for the BaseButton. This is needed since the BaseButton uses gui_input for detecting input and gui_input is only be called when has_point is true.
base_button_hit_margin.mp4