SplitContainer drag nested intersections#116734
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Mar 6, 2026
Merged
Conversation
kitbdev
force-pushed
the
sc-drag-nested-intersection
branch
from
d426ddf to
c26d122
Compare
ryevdokimov
approved these changes
Mar 5, 2026
Contributor
ryevdokimov
left a comment
ryevdokimov
left a comment
There was a problem hiding this comment.
Works, code looks fine to me.
2026-03-04.21-41-06.mp4
Contributor
|
Needs rebase |
kitbdev
force-pushed
the
sc-drag-nested-intersection
branch
from
c26d122 to
339bc4f
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
drag_nested_intersectionsto SplitContainer. It needs to be enabled on the ancestor and the descendant SplitContainer for them to recognize each other. It adds a dragger at the intersection of their draggers, the child of the ancestor SplitContainer's dragger that it is next to. They must be adjacent to each other as well, withinminimum_grab_thickness.The descendant should update the ancestor whenever it needs to update, usually on sort. There is one case where the ancestor needs to update all of its descendants, but it only happens when the property is just enabled and already in the tree, so it shouldn't be a performance concern.
I enabled this in the editor for the docks and for SplitContainers that can make use of this, like in the ScriptEditor.
drag-intersection-demo.mp4