Skip to content

Fix ios plugin always invalid due to null ConfigFile #106736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

TCROC
Copy link
Contributor

@TCROC TCROC commented May 22, 2025

Introduced by commit: 34f005d 4572994

That commit moved over the export_plugin.h to editor_export_platform_apple_embedded.h. They simply forgot to copy the memnew. Likely accidentally deleted during the refactor / rename.

This fixes all ios plugins / gdips being considered invalid and erroring with "Invalid plugin config file "

@bruvzg
Copy link
Member

bruvzg commented May 23, 2025

Seems like the same code on Android is also broken (by the same visionOS PR):

if (!plugins_filenames.is_empty()) {
Ref<ConfigFile> config_file;
for (int i = 0; i < plugins_filenames.size(); i++) {
PluginConfigAndroid config = PluginConfigAndroid::load_plugin_config(config_file, plugins_dir.path_join(plugins_filenames[i]));
if (config.valid_config) {
loaded_plugins.push_back(config);

@TCROC
Copy link
Contributor Author

TCROC commented May 23, 2025

Good catch! I'll add that fix in

@TCROC TCROC force-pushed the fix-ios-plugins-broken branch from 7ba7321 to a350e01 Compare May 23, 2025 15:41
@TCROC TCROC requested a review from a team as a code owner May 23, 2025 15:41
@TCROC
Copy link
Contributor Author

TCROC commented May 23, 2025

Seems like the same code on Android is also broken (by the same visionOS PR):

if (!plugins_filenames.is_empty()) {
Ref<ConfigFile> config_file;
for (int i = 0; i < plugins_filenames.size(); i++) {
PluginConfigAndroid config = PluginConfigAndroid::load_plugin_config(config_file, plugins_dir.path_join(plugins_filenames[i]));
if (config.valid_config) {
loaded_plugins.push_back(config);

Fixed! :)

@Repiteo Repiteo merged commit d5301d1 into godotengine:master May 26, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented May 26, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants