Metal: Disable MetalFX Temporal for mobile rendering method
#106731
Conversation
Calinou
added
bug
topic:rendering
topic:3d
cherrypick:4.4
Motion vectors added by that PR work differently from the ones in Forward+. They are rendered in a separate pass at a much lower resolution. They're intended to provide the data required for XR reprojection (asynchronous spacewarp) to work, rather than effects like TAA and motion blur. It might be possible to make them render at the same resolution as the viewport resolution, but since it's a separate pass, this may end up slower than in Forward+ (due to the cost of setting up the pass). In Forward+, motion vector computations are already quite expensive: #61905 |
| ERR_FAIL_COND_EDMSG(p_mode == RS::VIEWPORT_SCALING_3D_MODE_FSR && rendering_method != "forward_plus", "FSR1 is only available when using the Forward+ renderer."); | ||
| ERR_FAIL_COND_EDMSG(p_mode == RS::VIEWPORT_SCALING_3D_MODE_FSR2 && rendering_method != "forward_plus", "FSR2 is only available when using the Forward+ renderer."); | ||
| ERR_FAIL_COND_EDMSG(p_mode == RS::VIEWPORT_SCALING_3D_MODE_METALFX_TEMPORAL && rendering_method != "forward_plus", "MetalFX Temporal is only available when using the Forward+ renderer."); |
There was a problem hiding this comment.
That reminds me, is MetalFX Spatial implemented in the Mobile renderer? I'm curious about it, since we don't have working FSR1 in Mobile right now. (We could probably add it, but FSR1 is rather demanding on mobile devices when it's not in tweaked form like godotengine/godot-proposals#3786 or godotengine/godot-proposals#10411.)
There was a problem hiding this comment.
Apple's MetalFX are also optimised for their mobile devices, so they would still be usable there, but if the motion vectors are not viable for MetalFX Temporal upscaling, then we won't use it 👍🏻
There was a problem hiding this comment.
Tested locally, it works as expected.
I can confirm MetalFX Spatial is available and fully functional on the Mobile rendering method, unlike FSR 1.0 which acts like Bilinear (or the previously selected 3D scaling mode, to be precise). So this PR is good as it is.
It isn't supported, as `mobile` can't provide motion vectors. We can revisit once it is supported via godotengine#100283.
stuartcarnie
force-pushed
the
metal_fx_temporal_no_mobile
branch
from
298b959 to
fbe560a
Compare
|
Thanks! |
Closes #106665
It isn't supported, as
mobilecan't provide motion vectors. We can revisit once motion vector support is added via #100283.