Android: Add export option for custom theme attributes #106724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntaxerror247
force-pushed
the
theme-attributes
branch
2 times, most recently
from
b63f3c1 to
5d8dc85
Compare
m4gr3d
reviewed
May 22, 2025
m4gr3d
reviewed
May 22, 2025
m4gr3d
reviewed
May 22, 2025
m4gr3d
requested changes
May 22, 2025
syntaxerror247
force-pushed
the
theme-attributes
branch
4 times, most recently
from
51c21cd to
529e03d
Compare
m4gr3d
reviewed
May 23, 2025
m4gr3d
approved these changes
May 23, 2025
syntaxerror247
force-pushed
the
theme-attributes
branch
from
529e03d to
0ffbe5b
Compare
m4gr3d
reviewed
May 23, 2025
m4gr3d
approved these changes
May 23, 2025
- Regenerates the `GodotAppMainTheme` and `GodotAppSplashTheme` during Android export. Any manual changes to these styles will be cleared and replaced with default theme attributes. - Adds a new export option `gradle_build/custom_theme_attributes` for injecting custom theme attributes directly via the export window, avoiding the need to manually modify themes.xml.
syntaxerror247
force-pushed
the
theme-attributes
branch
from
0ffbe5b to
0312a0c
Compare
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate the
GodotAppMainThemeandGodotAppSplashThemeduring Android export. Any manual changes to this style will be cleared and replaced with default theme attributes.Adds a new export option
gradle_build/custom_theme_attributesfor injecting custom theme attributes directly via the export window, avoiding the need to manually modify themes.xml.It helps to avoid the issue I metioned in #106709 (comment).
According to the attributes shown in the image:
<item name="android:windowIsTranslucent">true</item>to the GodotAppMainTheme.[splash], so it adds the attribute to the GodotAppSplashTheme.