-
-
Notifications
You must be signed in to change notification settings - Fork 201
Remove 'teams' page. #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove 'teams' page. #1203
Conversation
The teams page was very outdated, and it incorrectly suggested contacting individual people for specific area work when RocketChat would have been more appropriate. The footer link, as well as stray visitors for the old page, will now be redirected to the contributing docs, which contains a more up-to-date view of the teams.
adamscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't remove pages/teams.html the current way it's done, as it would break every link that other people may have in other contexts. (i.e. somebody's presentation or something like that.)
Currently, the pages/teams.html already has a redirect_to parameter that redirects the user to the right page. So we could even let old links in the blogpost the same. I suggest that we don't change the contents of those either.
Shouldn't those be redirected to the new page automatically? What are you suggesting we do instead?
The reason I edited those is that, whenever the link of the new page might change (e.g. from |
I mean how it will be redirected if we remove the page that it links to and we don't tell the static site to redirect people to the new page? I may miss something, but if we remove the page, it will just not exist anymore at all, even the redirection. cc. @coppolaemilio |
I'm still not entirely sure I understand what you're saying. |
Sorry. I mistook the large diff with the removal of the file. Sorry. |
|
No worries, I'm just happy I understand now 😄 |
Note
It has not been decided yet whether this is the best way to handle the problems at hand.
The teams page is very outdated, and it suggests contacting individual people for specific area work. RocketChat is more more appropriate for contact, since the activity of maintainers ebbs and flows, and specific area contributors might know more about something specific anyway.
The footer link, as well as stray visitors for the old page, will be redirected to the contributing docs, which contains a more up-to-date view of the teams (and no names).
(we could also just remove the footer link?)
This removes the 'teams' tab from 'more':